Ticket #774 (closed defect: fixed)
Merge msDrawMap() and msDrawQueryMap()?
|Reported by:||dmorissette||Owned by:||mapserverbugs|
|Component:||MapServer C Library||Version:||4.3|
I spent several hours today trying to reproduce/isolate/debug the problem described in bug 773. It turns out at the end that this bug is probbaly caused by some things that aren't properly initialized in msDrawQueryMap() and that were implemented only in msDrawMap(). When I look at both functions, it seems that it would really make sense to merge them into a single function with a querymode true/false flag. The only difference between the two should be that in one case we hilight the layers that have query results and in the other case we don't, correct? At the moment the two functions are completely out of sync with respect to WMS, WFS, and other custom rendering stuff that's been added only to one of the two, I think that's just a source of potential bugs. Does anyone know of any reason why both functions could not be merged into a single function? For backwards compatibility we would maintain the same separate calls in MapScript. We would only change the core functions.
Note: See TracTickets for help on using tickets.