[WMS] msOWSGetLayerExtent() broken

[dmorissette]

Frank wrote:
-----

Daniel,

In msOWSGetLayerExtent() msOWSLookupMetadata() is called with the
namespace argument "WFCO".  I am not sure what the "W" is supposed to be, and
the WMS namespace ("M") is not included.  This is causing one of my autotests
(testing wms_extent support) to fail.

Is the msOWSLookupMetadata call correct?  Is this just a typo?

...
int msOWSGetLayerExtent(mapObj *map, layerObj *lp, rectObj *ext)
{
  static const char *value;

  if ((value = msOWSLookupMetadata(lp->metadata, "WFCO", "extent")) != NULL)
  {
...

[dmorissette]

This is definitely a typo and it should be "M". 

I have committed a fix to 4.3, together with an assert + error message in
msOWSLookupMetadata() to catch that case in the future.

Can you please confirm that this works for you and then I'll backport to 4.2

[fwarmerdam]

I have confirmed that Daniel's fix in 4.3 corrects my problem.  My test
script now passes. 

[dmorissette]

Ha!  It seems that I was smart enough to do only the minimum amount of changes
in the 4.2 branch when I did those msOWSLookupMetadata() changes before
4.2beta1... so the 4.2 code was still using the old method and was not broken. 
Only the 4.3 code used the new method.

Marking FIXED. Nothing to backport to 4.2.