Ticket #562 (closed enhancement: wontfix)

Opened 9 years ago

Last modified 9 years ago

Provide access to inline features through layerObj::getShape()

Reported by: sgillies@… Owned by: sgillies@…
Priority: high Milestone:
Component: MapScript Version: 4.1
Severity: minor Keywords:
Cc:

Description

Christoph Spoerri has provided tested code that allows MapScript access to
inline features that will be incorporated into SWIG MapScript.

One thing that bugs me about getShape is that the order of arguments is
tileindex, shapeindex.  This is exactly opposite of what it _should_ be.
Since not every call needs a tileindex, it should have been the second
argument so that we could make it optional.

Change History

Changed 9 years ago by sgillies@…

  • status changed from new to assigned
getShape should _really_ return *shapeObj, not an int, as do getLayer,
getClass, getStyle.


Changed 9 years ago by sgillies@…

layerObj.getShape now allows access to inline features through the 
msINLINELayerGetShape function in maplayer.c.  layerObj.getNumFeatures
uses msLayerGetNumFeatures().

Removing features from the linked list needs a little work yet.



Changed 9 years ago by dmorissette

Actually, when we implemented the PHP version of getShape() we made it return a
shapeObj:
     shapeObj getShape(int tileindex, int shapeindex)

Changed 9 years ago by sgillies@…

That was the right way.  I don't think we should change SWIG getShape now, but 
should wait till the next major version change.

As I said in an email to Cristoph yesterday, I decided against implementing a
method to remove inline features.  It's no good trying to treat a linked list
as if it is an array.  Maybe if we ever refactor layer->features to be an
array, but I don't think that is worth the effort.



Changed 9 years ago by sgillies@…

  • status changed from assigned to closed
  • resolution set to wontfix
Closing this bug.

Just a note to mention that I am resolving the issue of an improved
getShape method in bug 586.

http://mapserver.gis.umn.edu/bugs/show_bug.cgi?id=586
Note: See TracTickets for help on using tickets.