Opened 20 years ago

Closed 20 years ago

Last modified 20 years ago

#507 closed defect (fixed)

Template tag processor (written for HTML legends) doesn't allow quotes around arguments.

Reported by: sdlime Owned by: jlacroix
Priority: high Milestone:
Component: MapServer CGI Version: 4.1
Severity: normal Keywords:
Cc:

Description

The template processing code written for HTML legends doesn't support quoted 
attributes. Probably no big deal for HTML legends but for general use (eg. with 
shpxy tag) it is really limiting.

Steve

Change History (7)

comment:1 by dmorissette, 20 years ago

Cc: mapserver-bugs@… added
Owner: changed from sdlime to lacroix@…
Julien will have a look at this.

comment:2 by jlacroix, 20 years ago

Resolution: fixed
Status: newclosed
I implemented the support of double quotes around values.

The tag processor takes all the tag and split it on spaces. The difficulty here
was if the quoted tag contains spaces, like in a layer name for example. I've
did is replace all spaces inside the double quotes by double quotes (") and then
remove the starting and ending quotes. Then after the split, replace all double
quotes by space. 

The advantage of this is that the quotes does not change the way the tag are
processed because we remove them.

Marking as FIXED
However I did not tested with the shpxy tag, because I did not know how and I
did not find documentation on it.

Note that it's only implementated in 4.1

comment:3 by sdlime, 20 years ago

Sweet, I'll try with the shpxy tag and let you know if there are problems.

Steve

comment:4 by sdlime, 20 years ago

I've verified that double qoutes work (thanks by the way). Should we support
single quotes as well? Of course I tried single quotes as well. That would
eliminate any confusion. I'll let you guys reopen if necessary.

Steve

comment:5 by sdlime, 20 years ago

Julien: I know this one is marked as resolved but there is another related
problem. You can't have equal signs within a quoted argument (e.g.
proj="init=epsg:xxxx"). Might that be easily fixable? Seems that just about
anything should be allowed within the quotes.

Steve

comment:6 by dmorissette, 20 years ago

Created bug 507 about Steve's last question/issue.

comment:7 by dmorissette, 20 years ago

Doh! I meant bug 978
Note: See TracTickets for help on using tickets.