Ticket #472 (assigned defect)

Opened 10 years ago

Last modified 2 years ago

Clean up mapservObj member names...

Reported by: sdlime Owned by: sdlime
Priority: low Milestone: FUTURE
Component: MapServer CGI Version:
Severity: minor Keywords:
Cc:

Description (last modified by sdlime) (diff)

They are named unlike anything else in the code. There are a few vars in there
that have very cryptic names (e.g. LRN). This would involve some changes to
mapserv.c, mapserv_fcgi.c and maptemplate.c. I don't know how prevelant this
object is in the scripting envs.

Attachments

codingstyle.txt Download (3.3 KB) - added by dmorissette 9 years ago.
DMSG Coding Style

Change History

Changed 9 years ago by dmorissette

  • cc warmerdam@…, sgillies@…, mapserver-bugs@… added
  • milestone set to 4.4 release
mapservObj comes from our end, and the source of the problem is a collision
between our coding style and yours. Let's work on this together during the 4.3
release cycle to cleanup the mapservObj. 

Perhaps at the same time we could come up with a documented coding style that
mapserver developers should follow... it doesn't have to be long, just a few
guidelines on naming variables, files, indenting of code, etc.

Changed 9 years ago by sgillies@…

How about we use the wiki to document the minimum number of rules?
We could start here:

http://mapserver.gis.umn.edu/cgi-bin/wiki.pl?MapServerCodingStandards

I began with some style notes that impact the MapScript API, my 
particular area of interest.  I can adapt to whatever is decided for
C style in general.  I'm agnostic about braces, and like 4-space 
indentation.  No tabs.

Changed 9 years ago by dmorissette

DMSG Coding Style

Changed 6 years ago by sdlime

  • version 4.1 deleted
  • description modified (diff)
  • milestone changed from 5.0 release to 5.2 release

Since this is really just housekeeping it tends to slip. Here it goes again... to 5.2.

Steve

Changed 5 years ago by sdlime

I'm actually doing this as part of RFC 36 implementation.

Steve

Changed 5 years ago by sdlime

  • cc sgillies@… removed
  • status changed from new to assigned

Changed 5 years ago by sdlime

  • milestone changed from 5.2 release to 5.4 release

I'll finish this in 5.4...

Steve

Changed 3 years ago by dmorissette

  • milestone changed from 5.6 release to 6.0 release

Changed 2 years ago by sdlime

  • milestone changed from 6.0 release to FUTURE

Changed 2 years ago by sdlime

  • priority changed from high to low
Note: See TracTickets for help on using tickets.