Ticket #472 (assigned defect)

Opened 5 years ago

Last modified 2 months ago

Clean up mapservObj member names...

Reported by: sdlime Assigned to: sdlime (accepted)
Priority: high Milestone: 5.4 release
Component: MapServer CGI Version:
Severity: minor Keywords:
Cc:

Description (Last modified by sdlime) 

They are named unlike anything else in the code. There are a few vars in there
that have very cryptic names (e.g. LRN). This would involve some changes to
mapserv.c, mapserv_fcgi.c and maptemplate.c. I don't know how prevelant this
object is in the scripting envs.

Attachments

codingstyle.txt (3.3 kB) - added by dmorissette on 06/02/04 10:46:59.
DMSG Coding Style

Change History

04/17/04 01:24:18 changed by dmorissette

  • cc set to warmerdam@pobox.com, sgillies@frii.com, mapserver-bugs@dmsolutions.ca.
  • milestone set to 4.4 release.
mapservObj comes from our end, and the source of the problem is a collision
between our coding style and yours. Let's work on this together during the 4.3
release cycle to cleanup the mapservObj. 

Perhaps at the same time we could come up with a documented coding style that
mapserver developers should follow... it doesn't have to be long, just a few
guidelines on naming variables, files, indenting of code, etc.

05/29/04 18:50:04 changed by sgillies@frii.com 

How about we use the wiki to document the minimum number of rules?
We could start here:

http://mapserver.gis.umn.edu/cgi-bin/wiki.pl?MapServerCodingStandards

I began with some style notes that impact the MapScript API, my 
particular area of interest.  I can adapt to whatever is decided for
C style in general.  I'm agnostic about braces, and like 4-space 
indentation.  No tabs.

06/02/04 10:46:59 changed by dmorissette

  • attachment codingstyle.txt added.

DMSG Coding Style

08/08/07 01:50:58 changed by sdlime

  • version deleted.
  • description changed.
  • milestone changed from 5.0 release to 5.2 release.

Since this is really just housekeeping it tends to slip. Here it goes again... to 5.2.

Steve

04/12/08 11:40:55 changed by sdlime

I'm actually doing this as part of RFC 36 implementation.

Steve

05/15/08 23:19:02 changed by sdlime

  • status changed from new to assigned.
  • cc deleted.

06/21/08 09:01:57 changed by sdlime

  • milestone changed from 5.2 release to 5.4 release.

I'll finish this in 5.4...

Steve