Opened 12 years ago

Closed 12 years ago

#4224 closed task (fixed)

[PATCH] Drop code supporting GDAL < 1.5.0

Reported by: rouault Owned by: sdlime
Priority: normal Milestone: 6.2 release
Component: MapServer C Library Version: unspecified
Severity: normal Keywords:
Cc: warmerdam

Description

There are quite a few places in MapServer code that attempt to support building against GDAL < 1.5.0 with various #ifdef. I think this is unnecessary, and we could happily drop support for such antiquated GDAL versions (for reference: Debian Lenny, the oldstable, ships with GDAL 1.5.2) for MapServer 6.2

Attachments (1)

drop_old.gdal.patch (45.4 KB ) - added by rouault 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by warmerdam, 12 years ago

Even,

Please go ahead and apply this.

Thanks

comment:2 by dmorissette, 12 years ago

If we do this then we should probably also update mapogr.cpp to remove dependencies to versions < 1500

by rouault, 12 years ago

Attachment: drop_old.gdal.patch added

comment:3 by rouault, 12 years ago

Patch updated with big cleanup in mapogr.cpp

comment:4 by dmorissette, 12 years ago

We are probably using only the C API in mapogr.cpp with this patch, right? so we could probably rename it to mapogr.c after the patch.

comment:5 by rouault, 12 years ago

Yes, we only use C API now, but there are C++ constructs, like variable declarations not at the beginning of blocks. And I don't remember how svn mv works, but wouldn't that break svn blame ? (that's really a question)

comment:6 by rouault, 12 years ago

Resolution: fixed
Status: newclosed

Patch committed in r13210.

I've left aside the renaming of mapogr.cpp into mapogr.c. This is unrelated topic

Note: See TracTickets for help on using tickets.