Opened 13 years ago

Closed 13 years ago

#3859 closed defect (fixed)

CONNECTIONTYPE UNION & STYLEITEM "AUTO" problem with beta7 and rc1

Reported by: jmckenna Owned by: tamas
Priority: high Milestone: 6.0 release
Component: MapServer C Library Version: svn-trunk (development)
Severity: blocker Keywords:
Cc: cnieman

Description

Initially reported by Christy:

* ...However, if I have styling in the source layers (i.e. layer_1_for_union and layer_2_for_union) and use STYLEITEM "AUTO" in the union layer, the two source layers must have STATUS DEFAULT for anything to show up (which, I think, causes them to be drawn twice?). *

I've also tested and I confirm that there is a problem with beta7 and rc1 when using STYLEITEM "AUTO" on the union layer. I am attaching my example from the docs that works with beta6.

Attachments (2)

union-example.zip (58.9 KB ) - added by jmckenna 13 years ago.
mapfile and sample data
STYLEITEM_AUTO_example.zip (5.0 KB ) - added by cnieman 13 years ago.
Example of STYLEITEM AUTO still not working with expressions for me on Linux

Download all attachments as: .zip

Change History (20)

by jmckenna, 13 years ago

Attachment: union-example.zip added

mapfile and sample data

comment:1 by tamas, 13 years ago

Committed a fix in r11639

comment:2 by jmckenna, 13 years ago

  • trunk now works with the doc example for me (union with styleitem auto)

comment:3 by tamas, 13 years ago

applied a fix for an issue in r11664, thanks to Jana Golinowski

comment:4 by dmorissette, 13 years ago

Milestone: 6.0 release

Can we mark this one fixed now? Or is there another pending issue?

comment:5 by cnieman, 13 years ago

I'm currently recompiling to check.

comment:6 by cnieman, 13 years ago

Works for me as long as there is only one class in the source layers. Should it work with more than 1 class?

in reply to:  6 comment:7 by tamas, 13 years ago

Replying to cnieman:

Works for me as long as there is only one class in the source layers. Should it work with more than 1 class?

I hope so. Did you have an issue with this?

comment:8 by cnieman, 13 years ago

It seems that as long as I only have one class per source layer, and that the class doesn't have an EXPRESSION, it works. Once I add an EXPRESSION, the layer no longer draws.

I tried with two classes and no expression, and it draws as expected, using the styling from the first class.

comment:9 by jmckenna, 13 years ago

I can't reproduce this on Windows with trunk. On unix I get Christy's problem, and the ms_errorfile contains:

  [Mon May  9 20:40:47 2011].326101 msEvalExpression(): General error message. Can
      not evaluate expression, no item index defined.
  [Mon May  9 20:40:47 2011].326124 msEvalExpression(): General error message. Can
      not evaluate expression, no item index defined.
  ...

in reply to:  8 comment:10 by tamas, 13 years ago

Replying to cnieman:

It seems that as long as I only have one class per source layer, and that the class doesn't have an EXPRESSION, it works. Once I add an EXPRESSION, the layer no longer draws.

I tried with two classes and no expression, and it draws as expected, using the styling from the first class.

Just applied a fix for the expression problems in r11665. Any testing would be appreciated.

comment:11 by cnieman, 13 years ago

Just recompiled with r11665 and still seeing the same behaviour with the same errors Jeff posted in his last reply.

in reply to:  11 comment:12 by tamas, 13 years ago

Replying to cnieman:

Just recompiled with r11665 and still seeing the same behaviour with the same errors Jeff posted in his last reply.

Do you have a working example to reproduce this?

by cnieman, 13 years ago

Attachment: STYLEITEM_AUTO_example.zip added

Example of STYLEITEM AUTO still not working with expressions for me on Linux

comment:13 by jmckenna, 13 years ago

Also note that the errors that I reported earlier ("Cannot evaluate expression, no item index defined.") exist on Windows in the ms_errorfile as well, but the features are drawn correctly.

comment:14 by tamas, 13 years ago

Fixed the problem in r11667. Tests are welcomed

comment:15 by tamas, 13 years ago

Further fixes in r11668 and r11669

comment:16 by cnieman, 13 years ago

Just recompiled and it looks good now!

comment:17 by jmckenna, 13 years ago

also tested on windows and unix: works on both, and those 'no item index defined' errors are gone.

comment:18 by tamas, 13 years ago

Resolution: fixed
Status: newclosed

closing this one

Note: See TracTickets for help on using tickets.