multiple styles and binding do not work

[assefa]

a map with a binding on color with more that one style will not work:

CLASS

STYLE

WIDTH 6 COLOR [fillcolor]

END STYLE

WIDTH 3 COLOR [outlinecolor]

END

END

[sdlime]

Hmmm... Should work, will check.

Steve

[assefa]

I added the fix in r10498. It work with my test case.

[assefa]

patching also 5.6 r10499

[sdlime]

The fix doesn't look related to bindings at all? Steve

[assefa]

It is on the msDrawShape call, the last parameter of this function is querymapMode. The "querymapMode" parameter is used in msBindLayerToShape on some if the bindings like color. In this function the queymapmode is used on color and outlinecolor bindings. Hopefully it is the correct fix. I tried this in trunck and 5.6.

[sdlime]

Intuitively that doesn't seem like the right fix. I'll look to be sure though.

Steve

[petlof]

Any news on this.

I've got a similar problem with binded colors and multiple styles in the same CLASS. When drawing the first pass draws correctly (style 0) but when reaching the phase when drawing again from the cache most drawing is done with the wrong color.

It's not obvious what goes wrong for me, but it seems that the color-binding is not reevaluated during the cache-face which results in the cached features beeing drawn with the last color that was bound to that style during the first phase (could that be the case?)

When changing line 975 in mapdraw.c (5.6-trunk) to MS_FALSE instead to disable all cache-drawing everything is drawn as it should.

Style-Example:

CLASS
NAME "B"
EXPRESSION ("[dir]" == "B")
STYLE
 SYMBOL		'circle'
 SIZE		3
 ANTIALIAS	true
 COLOR		[fwcolor]                   
 OFFSET		3 -99
END
STYLE
 SYMBOL		'circle'
 SIZE		3
 ANTIALIAS	true
 COLOR		[bwcolor]                   
 OFFSET		-3 -99
END	
END

[sdlime]

Bump... Will look tonite.

Steve

[petlof]

Any news Steve? Do you need more input from me?

[sdlime]

Petlof, Assefa claims to have fixed this, I take it that's not the case with your last report? This is on my "todo" list before the feature freeze at the end of the week.

Steve

[petlof]

I will create a sample test-case for this and verify that its still a problem.

[petlof]

Hi, Issue still remains in 5.6-branch Se attached testdata

Shapefile with one field for rendercolor Two styles in same klass to draw two lines perpendicular against the shapeline.

The first style (drawn in the first pass) is drawn with the color from the field but when drawing second pass the field is not reevaluated and therefore all three lines are drawn with the last color from the first pass (blue in this case).

I've used this command for generating output shp2img.exe -m ms3538.map > test.png

[petlof]

Testcase for problem with multiple styles in same class

[petlof]

Output image displaying current output. All lines should have the same color on both paralell lines.

[petlof]

When changing line 988 to MS_FALSE the correct result is drawn.. as this attachment shows.

[sdlime]

I assume you mean 988 in mapdraw.c in the 5.6 branch. Not the fix obviously but a good clue. Assefa's early fix was correct there are more errors. Hmmm... Thanks for the test case.

Steve

[sdlime]

Actually I'm not sure about Assefa's early fix. The use of MS_TRUE there looks purposeful by tbonfort as part of his RFC 49 work. CC'ing him...

Steve

[sdlime]

Ok, I understand the problem. What happens with multi-style line layers is that we cache the lines and draw all features with each style in turn. This is done so intersections render correctly. msDrawShape() is called only for the first style (in general) and that's where the binding happens. So, by the time the cache is processed the styles have been re-bound to another feature and you see the result of the last bind- in the test case that's why every second style is drawn in blue.

I'm not sure of the fix. I guess we'd need to cache the styles (if necessary) in addition to the lines.

I'm going to hold off on a fix until the code sprint in a week and a half.

Steve

[assefa]

I can work/test that with you at the code sprint too.