php mapscript saveImage() to file still writes to stdout

[warmerdam]

The script:

<?php

//phpinfo();

dl("php_mapscript.so");

$map = ms_newMapObj("test.map");

// print $map->numlayers;
 
$img = $map->draw();

$img->saveImage("out.png",$map);

?>

working against trunk is resulting in the file out.png being written and then the png encoded again and written to stdout. Is it supposed to do this? I get the impression from the docs that it should not. The problem seems to be a missing return in the save to file case in saveImage. The attached patch seems to correct the issue. I hesitate to toapply it since I'm afraid I'm missing something.

[warmerdam]

fix saveImage problem.

[dmorissette]

I think you're right. This code has just been rewritten by Alan, so I'll let him test and apply the fix.

[aboudreault]

Thanks warmerdam.

Fixed and comitted in r10038.