Opened 14 years ago
Closed 13 years ago
#3377 closed defect (fixed)
OFFSET in style with SVG output
Reported by: | petlof | Owned by: | sdlime |
---|---|---|---|
Priority: | normal | Milestone: | 6.0 release |
Component: | Renderer API | Version: | 5.6 |
Severity: | normal | Keywords: | SVG, OFFSET |
Cc: | tbonfort |
Description
Style OFFSET on linelayers is not supported when outputting SVG as it is when drawing with GD.
I've attached a patch for mapsvg.c that adds functionality for drawing line-layers with offset in the same manner used for GD.
Perpendicular offset (offsetY = -99) is also supported in the same way as for GD output.
Attachments (3)
Change History (10)
by , 14 years ago
Attachment: | mapsvg_with_offset.patch added |
---|
comment:1 by , 14 years ago
Cc: | added |
---|
petlof,
thanks for the patch,
I'd prefer if the patch used the msOffsetPolyline function (in maputil.c) rather than duplicating once again the GD line offsetting code.
regards,
thomas
by , 14 years ago
Attachment: | mapsvg_offset_patch2.patch added |
---|
Better patch that uses msOffsetPolyline in maputils
comment:2 by , 14 years ago
tbonfort,
thanks for the tip,
i've changed the code and created a new patch that uses msOffsetPolyline instead.
comment:3 by , 13 years ago
Version: | 5.4 → 5.6 |
---|
comment:4 by , 13 years ago
Tbonfort: Sorry, I've not paid attention to this ticket. Ok to apply patch? Any implications for 6.0? I'm guessing a consistent offset algorithm is used in the high level rendering code.
Steve
comment:5 by , 13 years ago
That patch is outdated for 6.0, and there is effectively no need for it, the offsetting is done at a higher level.
not sure this is worth integrating into the 5.6 branch as petlof has his checkout patched and this doesn't seem to be affecting other people.
petlof, please comment back if this is something important for you.
comment:6 by , 13 years ago
I can manage with applying patch manually for 5.6 and 5.4 since it's very small. No need to integrate for me if you don't feel it's worth it.
comment:7 by , 13 years ago
Component: | MapServer C Library → Renderer API |
---|---|
Milestone: | → 6.0 release |
Resolution: | → fixed |
Status: | new → closed |
ok, closing as this is unrelevant for 6.0
Patch that adds offset funtionality to mapsvg