Ticket #3356 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

isValidItem is not aware of the OGR special attributes

Reported by: tamas Owned by: sdlime
Priority: normal Milestone: 5.6.2 release
Component: MapServer C Library Version: 5.6
Severity: critical Keywords:
Cc: dmorissette

Description

As of the addition of isValidItem (in MapServer 5.6) always generate an error if the mapfile contains OGR special attributes, like OGR:LabelText, OGR:LabelAngle

Change History

Changed 3 years ago by sdlime

  • status changed from new to assigned

I created a sandbox copy of the 5.6 branch to deal with this. Will let you know when I get it reverted to the 5.4 approach...

Steve

Changed 3 years ago by dmorissette

  • cc dmorissette added
  • milestone set to 5.6.2 release

Changed 3 years ago by sdlime

Tamas: I committed a fix to my sandbox 5.6 version:

 http://trac.osgeo.org/mapserver/browser/sandbox/sdlime/mapserver-5-6-bug3356

I think it fixes the issue by reverting to 5.4-like item detection albeit still supporting fetching all items as needed by the query functions. If you could test with OGR I'd appreciated. Ticket #3342 is also a result of these changes and I've asked Mike to test with Oracle.

I've got a number of query test cases for shapefiles and the CGI that output text (via templates) that I'd love to get into the test suite if someone could assist...

Steve

Changed 3 years ago by msmitherdc

Steve,

This resolves the issue for oracle. Works fine.

Mike

Changed 3 years ago by sdlime

Committed in 5.6 branch in r9936. -Steve

Changed 3 years ago by assefa

Steve,

Is there a reason why this is only done in 5.6 and not for the 6.0? I am trying to understand if there are changes on the function msLayerWhichItems upcoming for the next release.

I am looking at recent work done on this function since I am facing an issue where I need to define a list of attributes available for the kml output at draw time and looking best ways to fit that with the current needs.

Changed 3 years ago by sdlime

I put it in trunk last week but forgot to update this ticket. Are you seeing something different?

Steve

Changed 3 years ago by assefa

I did not see any thing different (I did not test it either). I was just checking on recent works regarding msLayerWhichItems and got aware of this bug.

My main concern is related to the possibilities of defining/selecting attributes at draw time that can be used for drivers such as kml. I think I will raise it in another bug/email since It is a different matter although it touches the same function.

Changed 3 years ago by assefa

as a reference I have entered #3356 related to msLayerWhichItems

Changed 3 years ago by assefa

oops meant #3450

Changed 3 years ago by sdlime

  • status changed from assigned to closed
  • resolution set to fixed

Closing this... For the record the fix removes isValidItem() as a check from the msLayerWhichItems() code.

Steve

Note: See TracTickets for help on using tickets.