Opened 14 years ago

Closed 14 years ago

#3236 closed defect (fixed)

Oracle Spatial - uninitialized local variable used in osPointCluster()

Reported by: jbartkowiak Owned by: aboudreault
Priority: normal Milestone: 5.6 release
Component: Input - Native Oracle Spatial Support Version: svn-trunk (development)
Severity: normal Keywords:
Cc: msmitherdc

Description

Compiling maporaclespatial.c with MSVC 2005 I got the following warning in osPointCluster() function:

...\maporaclespatial.c(1331) : warning C4700: uninitialized local variable 'n' used

I think this is a bug. Uninitialized 'n' variable is used as a malloc() size parameter.

Change History (3)

comment:1 by aboudreault, 14 years ago

Cc: msmitherdc added

msmitherdc, this is caused by a small mistake in the following patch: http://trac.osgeo.org/mapserver/attachment/ticket/3107/mapserver_4dbind.patch

I'm going to restore the following line:

n = (end - start)/2;

Is it ok for you, I suppose only the line after had to be commented?

comment:2 by msmitherdc, 14 years ago

This looks good for me.

comment:3 by aboudreault, 14 years ago

Resolution: fixed
Status: newclosed

Fixed and committed in r9618.

Note: See TracTickets for help on using tickets.