Reduce code duplication in mapsearch.c

[bretlambert]

The code for msIntersectPolylines() is shotgunned throughout mapsearch.c; this diff consolidates that code into calles to msIntersectPolylines(). I've measured improvements in map generation times after applying this patch (which is against 5.6.0-beta4), likely due to better CPU cache usage after shrinking the resulting binary by ~766kB (RAM access is expensive!).

[sdlime]

We love performance improvements. What sort of numbers did you see? CC'ing Dan to make sure it's ok to apply at this point...

Steve

[bretlambert]

Only tested it on a half-dozen files, but consistently 7-8% less time to generate the file, as reported by mapserver's output on the command line (and I'm pretty sure that it had to do with the workload under consideration, so YMMV, of course).

[sdlime]

I didn't see much of a difference in binary size, only about 4K but cleaner code is always a good thing... Applied in r9514.

Steve

[dmorissette]

Cool. :)