Problem with removeMetaData()

[dmorissette]

Robert Pivalone wrote to mapserver-dev:

Hi,

I have a problem with PHP Mapscript.

When I remove one metadata, two metadata are removed.

Mapserver : 5.2.1

Mapfile :
  LAYER
    NAME "Layer0"
 ...
    METADATA
      "PPPP"    "pppp"
      "rrrr"    "rrrr"
      "eeee"    "eeee"
      "description"    "mmmm"
      "type_aa"    "dddd"
      "ayyy_aa"    "aaaa"
    END
...
  END

Source code :
$oMap = ms_newMapObj($szMapFile);
$oLayer = $oMap->getLayerByName('Layer0');
$oLayer->removeMetaData('type_aa');
$oMap->save($szMapFile);

Expected result in the mapfile :
  LAYER
 ...
    METADATA
      "PPPP"    "pppp"
      "rrrr"    "rrrr"
      "eeee"    "eeee"
      "description"    "mmmm"
      "ayyy_aa"    "aaaa"
    END
...
  END

My result :
  LAYER
 ...
    METADATA
      "ayyy_aa"    "aaaa"
      "description"    "mmmm"
      "rrrr"    "rrrr"
      "PPPP"    "pppp"
    END
...
  END

Any idea ?

Thanks

[aboudreault]

The problem is that the key "eeee" and "type_aa" have the same hash value. So, both metadata are placed in the same linked list. In the code, the linked list was not properly updated for that specific case. I've made the change in r9376.

Assefa, may you confirm that the fix is ok ?

[assefa]

It seems good from what I can see. Tests are also successful with the example provided in this bug.

[aboudreault]

Fixed and committed in r9376. The linked list is not updated properly when it contains more than 1 element.