PHP mascript ResultCacheMemberObj Class is missing bounds and numresluts

[assefa]

ResultCacheMemberObj Class is missing bounds and numresults like the swig version

[assefa]

In fact the swig versions have 2 functions:

getResult : which returns a ResultCacheMemberObj getResults: which return a resultCacheObj

[assefa]

there is also a getNumResults method on the layer (both in swig and php). I think It would be better to build a resultCacheObj and expose both numresults and bounds so that the if other members are added to the structure, It would be easy to support them in php/mapscript

[sdlime]

Keep in mind this area of the code will be undergoing some change as part of the one-pass filtering. Not sure how/if the interface will change but it might.

Perhaps this fix should be target at 5.4.1 as well?

Steve

[assefa]

Good point. changing the target to 5.4.1.

[assefa]

Added the getResults method on the layer. Returns a resultcacheobj which has numresults and bounds as member of the object. committed in 5.4.x branch (r9099) Need to update docs

[assefa]

I believe this is still relevant for the 5.6/6.0 release.

[assefa]

Alan, is this still an issue?

[assefa]

please reopen if this is still an issue.

[worthlutz]

This is still an issue for 6.0. This capability was lost in 5.6 and I cannot find it in 6.0.

I am having to loop through the results to get the bounds of the result set to adjust the map extents to the area relavant to the query.

I was starting to move my application to 6.0 yesterday and decided to look for this in 6.0 and cannot find the method to get the bounds.

I am assuming that it would be best to calculate these bounds on the query pass and not have to loop through the results again. Sometimes I only need to loop through the 1st N results and not the whole set (except that I need the bounds for the whole set).

[aboudreault]

worthlutz, Is this available in other mapscript bindings? Steve, is this already computed in query pass? Is this something that could be added in a RC release?

[worthlutz]

I only use PHP mapscript and do not know about the others.

[sdlime]

The resultCacheObj still contains a "bounds" rectObj and it's still being populated as part of query processing (see addResult() in mapquery.c).

For Swig-based languages the numresult and bounds members are accessible (but immutable).

Steve

[aboudreault]

So, I should create a resultCacheObj PHP object then.

[aboudreault]

I'm not going to add a new object since the numresults is already exposed via layer->getNumResults(). I'm going to add a method getResultsBounds() in the layer object.

[sdlime]

Should probably have the same method in Swig-land then (layer.i)...

Steve

[aboudreault]

Fixed and committed in r11643. worthlutz, could you test it and confirm it does the job? Steve, SWIG already have the resultCacheObj exposed... Do you want I remove it and create a similar method in the layer.i ? or we let things as they are?

[sdlime]

I mis-spoke. Looks like the resultcache object is hidden from Swig so we'll need the same method added to layer.i.

Steve

[aboudreault]

Added swig method in r11645. Steve, could you test it in perl?

[sdlime]

Seems to work just dandy... Steve

[worthlutz]

Works with PHP mapscript. Removes a loop from my code. Thanks!

[havatv]

Attemted a fix for 6.0 and trunk documentation in r12036. Only added getresultsbounds (php and swig - very brief description). Please reopen with more instructions if more work is needed.