WMS 1.1.1 GetMap produces WFS error about SERVICE parameter missing

[dmorissette]

With MapServer 5.2, a WMS 1.1.1 GetMap request without the (optional) SERVICE results in the following error:

msWFSDispatch(): WFS server error. Incomplete WFS request: SERVICE parameter missing

The SERVICE parameter is optional with WMS 1.1.1 GetMap, it is required only for GetCapabilities. This prevents some WMS clients from working with MapServer 5.2.0

[dmorissette]

The problem is caused by a modification made to msWMSDispatch() to return right away if SERVICE is missing in r7363 for ticket #2495.

According to ticket #2495, this was done to prevent some issues with SOS POST requests, but ticket #2495 is very vague on what the exact issues were. Obviously requiring the service parameter before checking for WMS requests is not correct since SERVICE didn't exist in WMS 1.0.0 and is optional for GetMap in WMS 1.1.1

Adding tomkralidis to CC to get his comments on this before reverting his change.

[dmorissette]

TomK has tested and confirmed that removing the test that was introduced in r7363 (return right away if SERVICE is missing in msWMSDispatch) doesn't cause a regression of #2495.

Fixed in r7850 in SVN trunk by removing the test that requires SERVICE for WMS in all cases. There is still code further down in the function that enforces requirement of the service param for specific WMS versions/requests.

Fix backported to 5.2.x branch in r7851 (will be in 5.2.1)