PHP MapScript vs ZEND_DEBUG

[dmorissette]

alim karim wrote on mapserver-users:

i'd leave it to the development guys to make the call on whether --enable-debug should automatically change the ZEND_DEBUG flag - it would be nice if it did.

And I replied:

I don't think --enable-debug should also set the ZEND_DEBUG flag in php_mapscript.c because we sometimes (often in my case) want MapServer/MapScript in debug mode but with a regular (non-debug) PHP build, so the two are not directly linked.

That being said, a new --enable-php-debug configure option could possibly be added, or if possible we should consider removing that hardcoded ZEND_DEBUG define in php_mapscript.c since the value is presumably set already in the zend headers and we should not mess with it in our own code.

[aboudreault]

I agree with the fact that we should simply use the ZEND_DEBUG value, which is in the header "php.h"... unless you see any problems with that ?

[dmorissette]

Let's remove the hardcoded ZEND_DEBUG define in php_mapscript.c since php.h already provides it and setting a value other than that of php.h is asking for trouble anyway.

[aboudreault]

Fixed and committed in r9155. There is no more ZEND_DEBUG define in PHP/Mapscript, it uses the ZEND_DEBUG from the PHP source.

[assefa]

add a building flag for windows r9275.

As a note removing ZEND_DEBUG was causing a build problem on windows. Usually we do not build using php_config.h.in on windows where ZEND_DEBUG is supposed to be defined. add a building flag for windows r9275.