Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#2664 closed defect (fixed)

configure does not work for fribidi2

Reported by: woodbri Owned by: dmorissette
Priority: normal Milestone: 5.2 release
Component: Build Problems Version: svn-trunk (development)
Severity: normal Keywords:
Cc: dmorissette, aboudreault

Description

It looks like fribdi2 has changed from using fribidi-config to using pkg-config and this prevents the configure from finding that it has been installed. I built fribidi2 from source and installed it in /usr/local

Daniel Morissette wrote:
> Stephen Woodbridge wrote:
>>
>> mapserver expects
>>
>> --with-fribidi-config=yes
>> --with-fribidi-config=/path/to/fribidi-config
>>
>> BUT the fribidi2 download does not appear to build one!
>>
>> Anyone go any ideas?
>>
>
> I just checked and the previous release (fribidi-0.10.9) did include one, so it
> seems that the fribidi-config script was dropped in fribidi-0.19.1.
>
> Sounds like someone needs to ask about this on their dev list. I think Alan was
> on that list when he worked on that so maybe he could ask.
>
> Daniel

> I'm not aware of any ticket for this. FYI it seems that fribidi-config was
> dropped > in favor of pkg-config. Here is the response we got from their list:

> > Yes.  Dropped in favor of pkg-config.
> >
> > [behdad:0 ~]$ pkg-config --cflags fribidi
> > -I/home/behdad/.local/include/fribidi  [behdad:0 ~]$ pkg-config --libs fribidi
> > -L/home/behdad/.local/lib -lfribidi  

Attachments (2)

configure.patch (3.2 KB ) - added by aboudreault 16 years ago.
mapstring.patch (386 bytes ) - added by aboudreault 16 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by dmorissette, 16 years ago

Cc: dmorissette added
Owner: changed from mapserverbugs to aboudreault

Alan, could you please check this one?

comment:2 by aboudreault, 16 years ago

Ok, i modified the configure.in to support pkg-config and fribidi2. There is a new option that we can use: --with-pkg-config[=path] : to specify the /path/to/pkg-config. By default, autoconf will check if the system has pkg-config in it default path. Otherwise set the $PKG_CONFIG to "no".

Now, the --with-fribidi-config can be:

  • no: ...
  • yes: Autoconf will check if the system has fribidi-config. If not, it will check if the pkg-config has fribidi in it's packages list.
  • path to fribidi-config for fribidi
  • path to fribidi.pc for fribidi2

I joined the two path files. (mapstring.c path is because pkg-config and fribidi-config do not return the same include path)

by aboudreault, 16 years ago

Attachment: configure.patch added

by aboudreault, 16 years ago

Attachment: mapstring.patch added

comment:3 by dmorissette, 16 years ago

Owner: changed from aboudreault to dmorissette
Status: newassigned

I have applied the patches in r7771, in time for 5.2.0-beta4.

Leaving ticket open to add relevant updates to README.CONFIGURE

comment:4 by dmorissette, 16 years ago

Cc: aboudreault added

comment:5 by dmorissette, 16 years ago

Resolution: fixed
Status: assignedclosed

Closing FIXED. README.CONFIGURE updated in r7772.

comment:6 by dmorissette, 16 years ago

SteveW reported the following error that is fixed in r7780:

Daniel,

Trivial testing looks good. I tried it on a couple of systems and also tried 
--with-fribidi-config=../fribidi/fribidi.pc  which worked fine also.

I did get one error below but it seemed to configure and build ok.

./configure: line 11962: =: command not found
Note: See TracTickets for help on using tickets.