relax FORMAT parameter restrictions for GetFeatureInfo

[tomkralidis]

" -in ArcGIS 9.1 GetFeatureInfo did not work since ArcGIS did not send the required LAYERS parameter -in ArcGIS 9.2 GetFeatureInfo worked as text/plain

Now it turns out that 9.2 does not work against Mapserver 5.0.X, since it omits the FORMAT parameter in the request and Mapserver checks on this. I must admit that I find it strange that this parameter is required for GetFeatureInfo as it makes no sense at all for those requests. "

[tomkralidis]

Bart: I've made this change in trunk in r7385. Note that the FORMAT constraint still exists for GetMap. Once you confirm, I will backport to branch-5.0.

[bartvde]

Hey Tom,

for GetLegendGraphic FORMAT is also required. Are you able to change that as well? Might it not be easier checking for GetFeatureInfo instead of checking for both GetMap and GetLegendGraphic?

if (formatfound == 0 && (strcasecmp(request, "GetFeatureInfo") == 1 || strcasecmp(request, "featureinfo") == 1)) 

Bart

[tomkralidis]

Bart: FYI FORMAT is still required and checked for GetLegendGraphic (goes through a different validation path) -- see mapwms.c line 2661.

Is this okay?

[bartvde]

Ah right, sorry for the confusion. This looks good to me and ready to go.

[tomkralidis]

Done in branch-5.0 in r7386. Closing.