A GetCapabilities request sent to a SOS 1.0.0 server with an invalid format for the acceptversions parameter must return an exception

[nsavard]

When a GetCapabilities request that contains an invalid format for the acceptversions parameter, is sent to a SOS 1.0.0 server, an exception must be triggered. The ExceptionReport shall have the "VersionNegotiationFailed" exception code. The locator must not be present.

The concerned test is: owsTests:ows-OWS.GetCapabilities-AcceptVersions.3 (s0003)

and the request sent is: ​http://dev1.lan.mapgears.com/manwe/cgi-bin/mssos100_ogc_cite?request=GetCapabilities&service=SOS&acceptversions=2000-01-01

[tomkralidis]

This is OWS Common style of version negotation. The base functionality was implemented as part of #996. Nothing in the codebase calls msOWSCommonNegotiateVersion, until SOS 1.0.0.

[tomkralidis]

Fixed:

• in trunk in r7391
• in msautotest in r7392

Norm: can you check and verify?

[nsavard]

Replying to tomkralidis:

Fixed:

• in trunk in r7391
• in msautotest in r7392

Norm: can you check and verify?

An exception is triggered and the test passed but I see in the exception report the "WMS" string. <?xml version="1.0" encoding="ISO-8859-1"?> <ows:ExceptionReport xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:ows="http://www.opengis.net/ows/1.1" version="1.0.0" xml:lang="en-US" xsi:schemaLocation="http://www.opengis.net/ows/1.1 http://schemas.opengis.net/ows/1.1.0/owsExceptionReport.xsd">

<ows:Exception exceptionCode="VersionNegotiationFailed" locator="acceptversions">

<ows:ExceptionText>msSOSGetCapabilities(): SOS server error. Invalid version format.

msOWSParseVersionString(): WMS server error. Invalid version (2000-01-01). OWS version must be in the format 'x.y' or 'x.y.z'</ows:ExceptionText>

</ows:Exception>

</ows:ExceptionReport>

[tomkralidis]

I fixed this by adding a generic "OWS error" code to maperror.c.

Fixed in trunk r7395 and msautotest in r7396

The test nonetheless passes as this was a cosmetic fix.

Norm: can we close?

[nsavard]

Replying to tomkralidis:

I fixed this by adding a generic "OWS error" code to maperror.c.

Fixed in trunk r7395 and msautotest in r7396

The test nonetheless passes as this was a cosmetic fix.

Norm: can we close?

Yes you can.