Ticket #2494 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

WMS GetLegendGraphic doesn't listen to TRANSPARENT in OUTPUTFORMAT

Reported by: bartvde Assigned to: tomkralidis
Priority: normal Milestone: 5.0.3 release
Component: WMS Server Version: unspecified
Severity: normal Keywords:
Cc: nsavard, dmorissette

Description

Whereas mode=legend does listen to this to determine whether or not the legend should be transparent.

Attachments

ticket2494.patch (454 bytes) - added by bartvde on 02/07/08 08:34:19.
patch fixing the issue
mapwms.c-ticket2494.patch (0.5 kB) - added by tomkralidis on 02/07/08 08:47:47.
new patch against latest svn trunk

Change History

02/07/08 08:34:19 changed by bartvde

  • attachment ticket2494.patch added.

patch fixing the issue

02/07/08 08:47:47 changed by tomkralidis

  • attachment mapwms.c-ticket2494.patch added.

new patch against latest svn trunk

(follow-up: ↓ 4 ) 02/07/08 08:50:49 changed by tomkralidis

  • cc set to nsavard.

Bart: I've added a new patch based on the latest svn trunk (I made a bunch of changes for #2384 last night).

Note that we should probably add msautotest/wxs test cases for this (we have none for GetLegendGraphic). Norm: if you can provide some info on how to add binary outputs for msautotest/wxs, then I can add.

02/07/08 08:54:56 changed by bartvde

Hi Tom, is this something you only want to fix in trunk or also in 5.0.3?

02/07/08 08:59:26 changed by tomkralidis

Right. Both. I'll wait for someone on mapserverbugs to commit this to both, then I'll work on the msautotest/wxs cases.

(in reply to: ↑ 1 ) 02/07/08 09:18:52 changed by nsavard

Replying to tomkralidis:

Bart: I've added a new patch based on the latest svn trunk (I made a bunch of changes for #2384 last night). Note that we should probably add msautotest/wxs test cases for this (we have none for GetLegendGraphic). Norm: if you can provide some info on how to add binary outputs for msautotest/wxs, then I can add.

Tom:

If you are talking about how to output image than here is an example (tomkworkshop.map). You only have to add RESULT_DEMIME.

# Generate WMS GetLegendGraphic? # RUN_PARMS: wms_get_legend_graphic.png [MAPSERV] QUERY_STRING="map=[MAPFILE]&version=1.1.1&service=WMS& request=GetLegendGraphic?&layer=rivers&format=image/png" > [RESULT_DEMIME]

02/12/08 08:36:48 changed by dmorissette

  • owner changed from mapserverbugs to tomkralidis.

Tom, I reviewed the patch and it seems safe. I'd say go ahead and commit to both trunk and branch-5-0.

02/12/08 08:37:05 changed by dmorissette

  • cc changed from nsavard to nsavard, dmorissette.

02/12/08 08:50:52 changed by tomkralidis

  • status changed from new to closed.
  • resolution set to fixed.

Done:

  • change made in trunk in r7369
  • change made in branch-5-0 in r7370
  • since msautotest/wxs already had a GetLegendGraphic test, I did not add one