Opened 12 years ago

Closed 12 years ago

#2494 closed defect (fixed)

WMS GetLegendGraphic doesn't listen to TRANSPARENT in OUTPUTFORMAT

Reported by: bartvde Owned by: tomkralidis
Priority: normal Milestone: 5.0.3 release
Component: WMS Server Version: unspecified
Severity: normal Keywords:
Cc: nsavard, dmorissette

Description

Whereas mode=legend does listen to this to determine whether or not the legend should be transparent.

Attachments (2)

ticket2494.patch (454 bytes) - added by bartvde 12 years ago.
patch fixing the issue
mapwms.c-ticket2494.patch (559 bytes) - added by tomkralidis 12 years ago.
new patch against latest svn trunk

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by bartvde

Attachment: ticket2494.patch added

patch fixing the issue

Changed 12 years ago by tomkralidis

Attachment: mapwms.c-ticket2494.patch added

new patch against latest svn trunk

comment:1 Changed 12 years ago by tomkralidis

Cc: nsavard added

Bart: I've added a new patch based on the latest svn trunk (I made a bunch of changes for #2384 last night).

Note that we should probably add msautotest/wxs test cases for this (we have none for GetLegendGraphic). Norm: if you can provide some info on how to add binary outputs for msautotest/wxs, then I can add.

comment:2 Changed 12 years ago by bartvde

Hi Tom, is this something you only want to fix in trunk or also in 5.0.3?

comment:3 Changed 12 years ago by tomkralidis

Right. Both. I'll wait for someone on mapserverbugs to commit this to both, then I'll work on the msautotest/wxs cases.

comment:4 in reply to:  1 Changed 12 years ago by nsavard

Replying to tomkralidis:

Bart: I've added a new patch based on the latest svn trunk (I made a bunch of changes for #2384 last night).

Note that we should probably add msautotest/wxs test cases for this (we have none for GetLegendGraphic). Norm: if you can provide some info on how to add binary outputs for msautotest/wxs, then I can add.

Tom:

If you are talking about how to output image than here is an example (tomkworkshop.map). You only have to add RESULT_DEMIME.

# Generate WMS GetLegendGraphic? # RUN_PARMS: wms_get_legend_graphic.png [MAPSERV] QUERY_STRING="map=[MAPFILE]&version=1.1.1&service=WMS& request=GetLegendGraphic?&layer=rivers&format=image/png" > [RESULT_DEMIME]

comment:5 Changed 12 years ago by dmorissette

Owner: changed from mapserverbugs to tomkralidis

Tom, I reviewed the patch and it seems safe. I'd say go ahead and commit to both trunk and branch-5-0.

comment:6 Changed 12 years ago by dmorissette

Cc: dmorissette added

comment:7 Changed 12 years ago by tomkralidis

Resolution: fixed
Status: newclosed

Done:

  • change made in trunk in r7369
  • change made in branch-5-0 in r7370
  • since msautotest/wxs already had a GetLegendGraphic test, I did not add one
Note: See TracTickets for help on using tickets.