Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#2416 closed defect (fixed)

allow for USE_LIBXML2 ifdef

Reported by: tomkralidis Owned by: warmerdam
Priority: normal Milestone: 5.2 release
Component: Build Problems Version: svn-trunk (development)
Severity: normal Keywords: libxml
Cc: dmorissette, jmckenna

Description

irc chunk below says it all:

[17:10]	<tomkralidis>	next question: when we initially started working with libxml2, we wrapped all code that used it within #ifdef USE_SOS_SVR. This includes mapowscommon.*, and mapogcsos.c.
[17:11]	<tomkralidis>	Now that maplibxml2.c exists, and FrankW's forthcoming WCS 1.1 work which uses libxml2, should we think about changing the ifdef? It's more than just SOS now
[17:12]	* tomkralidis	wonders if a more generic USE_LIBXML2 would be more applicable
[17:13]	<hobu>	yes, the #ifdef should probably change now

...so that resulting files will test for USE_LIBXML2 instead.

Change History (5)

comment:1 by warmerdam, 16 years ago

Cc: warmerdam removed
Keywords: libxml added
Owner: changed from mapserverbugs to warmerdam

I'll take care of this as part of my WCS 1.1 commit (using libxml).

comment:2 by tomkralidis, 16 years ago

FYI additionally, mapogcsos.c, maplibxml2.c, mapowscommon.c, mapgml.c, mapogcfilter.c now use USE_LIBXML2

comment:3 by tomkralidis, 16 years ago

Frank: any other testing/etc. needed for this?

comment:4 by warmerdam, 16 years ago

Resolution: fixed
Status: newclosed

Based on a quick skim, it seems this is working well now. Closing the ticket.

comment:5 by jmckenna, 16 years ago

Cc: jmckenna added
Note: See TracTickets for help on using tickets.