Opened 17 years ago

Closed 17 years ago

#2360 closed defect (fixed)

WMS: image/wbmp should be image/vnd.wap.wbmp

Reported by: bartvde Owned by: tomkralidis
Priority: normal Milestone: 5.2 release
Component: WMS Server Version: svn-trunk (development)
Severity: normal Keywords:
Cc: tomkralidis

Description

currently in a WMS GetCapabilities response Mapserver advertizes image/wbmp, this should however be image/vnd.wap.wbmp according to:

http://www.iana.org/assignments/media-types/image/

E-mail thread:

Kralidis,Tom [Burlington] wrote:

You're right; image/vnd.wap.wbmp seems to be the definitive way to define a wbmp MIME type. I'm not sure of the history of image/wbmp in MapServer or how it got there, however.

I also wonder on how much image/wbmp is used. Would be interesting to hear other dev's thoughts here.

We probably didn't do much research before deciding to go with image/wbmp ... we probably just assumed that it was the right MIME type to use based on others (image/gif, image/jpeg, etc.).

I don't know how much WBMP is used today, or if at all via WMS, but it's there and has been used in the past so I would not remove it unless we really have to. I'd suggest we file a ticket about switching from image/wbmp to image/vnd.wap.wbmp, with a pointer to the authoritative resource that defines image/vnd.wap.wbmp, and then we could make the change in MapServer. Ideally we'd make the change only in 5.2, but if we really have to we could backport to 5.0.x.

Daniel -- Daniel Morissette http://www.mapgears.com/

Change History (4)

comment:1 by tomkralidis, 17 years ago

Cc: tomkralidis added

comment:2 by tomkralidis, 17 years ago

This occurs in 3 files:

$ clear;grep -i "image/wbmp" *.[ch] mapoutput.c: format->mimetype = strdup("image/wbmp"); mapwms.c: mimetype = strdup("image/wbmp");

mapwmslayer.c:
strcasecmp(papszTok[i], "image/wbmp")

I'll make the necessary changes.

comment:3 by dmorissette, 17 years ago

Owner: changed from mapserverbugs to tomkralidis

comment:4 by tomkralidis, 17 years ago

Resolution: fixed
Status: newclosed

Sorry, here's comment:2 with better formatting:

$ clear;grep -i "image/wbmp" *.[ch]
mapoutput.c:        format->mimetype = strdup("image/wbmp");
mapwms.c:                         mimetype = strdup("image/wbmp");
mapwmslayer.c:                || strcasecmp(papszTok[i], "image/wbmp")

Based on this (i.e. there were GD driver specific WBMP defs which I did not touch),

  • mapserver changes made in r6969
  • HISTORY.txt updated
  • msautotest changed made in r6970
Note: See TracTickets for help on using tickets.