Opened 17 years ago

Closed 16 years ago

#2354 closed defect (fixed)

Problem with 3D shapes with the mapserver shape driver

Reported by: tamas Owned by: sdlime
Priority: normal Milestone: 5.0.1 release
Component: MapServer C Library Version: unspecified
Severity: normal Keywords:
Cc: warmerdam, assefa

Description

Currently mapserver cannot display the 3D shapes properly when the built-in shape driver is used even if USE_POINT_Z_M is enabled during the compilation.

More information:

msSHPReadBounds in mapshape.c is not aware of the 3D point features, and these features are treated as non point features so the returning rect is invalid.

For fixing the issue in ln 1293

if (psSHP->nShapeType != SHP_POINT) {

should be replaced with

if (psSHP->nShapeType != SHP_POINT && psSHP->nShapeType != SHP_POINTZ) {

We should probably add similar checks for SHP_POINTM as well.

Attachments (1)

brklinz.zip (21.8 KB ) - added by warmerdam 17 years ago.
3D (XYZ) Line file (breaklines).

Download all attachments as: .zip

Change History (7)

comment:1 by warmerdam, 17 years ago

Cc: warmerdam added
Component: Shapefile UtilitiesMapServer C Library
Milestone: 5.0.1 release

Changed to C library (or is it really just affecting utilities?) and 5.0.1 release since this seems like a serious bug.

I'll leave this bug to Steve, but call on me if needed.

comment:2 by sdlime, 17 years ago

Cc: assefa added

comment:3 by sdlime, 17 years ago

Status: newassigned

Anybody got test Z and M shapefiles laying around that they could post here?

Steve

in reply to:  3 comment:4 by tamas, 17 years ago

Replying to sdlime:

Anybody got test Z and M shapefiles laying around that they could post here?

Steve

Here's the link we got from who has reported this issue

http://www.nabble.com/file/p13289551/data.zip

by warmerdam, 17 years ago

Attachment: brklinz.zip added

3D (XYZ) Line file (breaklines).

comment:5 by sdlime, 16 years ago

I made the changes suggested by Tamas in the 5.0 branch and the trunk. I'd be obliged if someone could confirm that this works for them.

Steve

comment:6 by sdlime, 16 years ago

Resolution: fixed
Status: assignedclosed

I tried with both line (which I believe worked in the past) and point shapefiles and all was ok. Closing...

Steve

Note: See TracTickets for help on using tickets.