Opened 17 years ago

Closed 17 years ago

#2276 closed defect (fixed)

process.h must be included in maptemplate.h because maptemplate uses getpid

Reported by: hobu Owned by: hobu
Priority: normal Milestone: 5.0 release
Component: MapServer C Library Version: svn-trunk (development)
Severity: normal Keywords:
Cc: dmorissette, tomkralidis, warmerdam

Description

This change (from quite a while ago) ​http://trac.osgeo.org/mapserver/changeset/4499 introduced using getpid. It seems we don't have process.h included for maptemplate, however.

fixed in r6742

Change History (6)

comment:1 by hobu, 17 years ago

Resolution: → fixed
Status: new → closed
Version: unspecified → svn-trunk (development)

comment:2 by dmorissette, 17 years ago

Resolution: fixed
Status: closed → reopened

Howard, the new include breaks the build on Linux: 

In file included from maptemplate.c:29:
maptemplate.h:35:21: error: process.h: No such file or directory

Is it possible that process.h is windows-specific? For sure on Linux it's not required and we get no warning about getpid being implicitly defined or anything like that.

Actually, what were the symptoms that got you to file this ticket? Warnings? Build errors? And on which platform?

comment:3 by dmorissette, 17 years ago

Cc: tomkralidis added
Owner: changed from sdlime to hobu
Status: reopened → new

comment:4 by warmerdam, 17 years ago

Cc: warmerdam added

I have changed to only include process.h in windows (but non-cygwin) builds, and to move it to mapserver.h with many other windows specific includes (r6745).

comment:5 by tomkralidis, 17 years ago

I confirm that r6745 works for me now (on fc7)

comment:6 by dmorissette, 17 years ago

Resolution: → fixed
Status: new → closed

Marking fixed again.

Note: See TracTickets for help on using tickets.