Ticket #2233 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Polygon outline thickness keeps growing and growing...

Reported by: sdlime Owned by: tbonfort
Priority: normal Milestone:
Component: AGG Version: unspecified
Severity: normal Keywords:
Cc: tbonfort

Description (last modified by sdlime) (diff)

Polygon outlines, e.g.

STYLE
  COLOR 0 153 204
  OUTLINECOLOR 102 204 255
END

should always be 1 pixel but with AGG they seem to be being scaled. Here's an example:

 http://www.dnr.state.mn.us/maps/compass-agg.html?map=%2Fusr%2Flocal%2Fwww%2Fdocs_maps%2Fcompass%2Fview-agg.map&imgext=439030.854851+5148791.548562+447277.030960+5155935.294710&mode=browse&zoomdir=1&zoomsize=2&layers=&imgxy=187.5+162.5&imgbox=-1+-1+-1+-1

The lakes are drawn with style above. I would expect a 1 pixel outline at all scales. Thick outlines require a seperate style since there's no way to specify outline size in a style.

Change History

Changed 6 years ago by sdlime

  • description modified (diff)

Changed 6 years ago by tbonfort

yep I see... actually for a shade symbol I've been treating WIDTH as the outline width drawn around the polygon, which does make it easy to specify that kind of styling. And width is scaled by the scalefactor which seems to be the problem here.

What's the use case of the 'scalefactor' param for all these functions. here's the first time I've actually seen it kicking in at something != 1

Changed 6 years ago by tbonfort

  • owner changed from sdlime to tbonfort

should be fixed with r6598, you can close this once you've confirmed.

By the way, the WIDTH param has multiple meanings depending on context. I'd be quite keen on introducing an OUTLINEWIDTH keyword to disambiguate. (which could take floating point values, thin outlines with agg are cool ;)

Changed 6 years ago by sdlime

  • status changed from new to closed
  • resolution set to fixed

Scale factors are can be something other than 1 when SYMBOLSCALE is set at the layer level. Both width and size can be scaled, as could a symbol PATTERN or GAP.

Could consider OUTLINEWIDTH for 5.2. Should look at the SLD specs to see what that specifies. There are other params to consider too like miter and cap.

I was thinking that both WIDTH and SIZE should be made doubles.

(BTW, your fix worked, closing...)

Steve

Note: See TracTickets for help on using tickets.