mapowscommon.c/.h dependent on USE_SOS_SVR

[dmorissette]

mapowscommon.h includes the following:

#include<libxml/parser.h> #include<libxml/tree.h>

and for this reason my build fails if I don't inlude libxml in my config options (I don't have libxml in the system dirs).

Frank had apparently come accross a similar issue as well and added a #ifdef USE_SOS_SVR in mapowscommon.c in r5841, but this doesn't sound right., i.e. should the OWS common stuff really be dependent on the USE_SOS_SVR def? Should it not have its own USE_OWS_COMMON which in turn will require libxml in the configure script?

We need to decide whether testing USE_SOS_SVR is appropriate for mapowscommon.c/.h and create a new USE_OWS_COMMON if required that can be enabled by configure.in only if libxml is present.

[dmorissette]

As a temporary fix, I have added a #ifdef USE_SOS_SVR in mapowscommon.h r6122 ... and my build passes now.

[tomkralidis]

I guess that depends on the future of using libxml2 in MapServer. USE_SOS_SVR is defined only because SOS is the only OGC specification which uses mapowscommon.c right now. There are plans to move WCS to libxml2 support as well.

[dmorissette]

Let's close this as WONTFIX then... and keep in mind that down the road if other specs start using mapowscommon.c/.h then it might make sense to create a USE_OWS_COMMON def.