[SLD] Error messages in SLD

[assefa]

<Tom.Kralidis@EC.GC.CA> wrote:

> 
>
>Assefa: perhaps a check is in order in the code to see if OGR is on
>(this should probably be a check in the build process too, or instead)?
>
  There is a check in the code for OGR and and error message is set when ogr is
not available.  But this error is not ignored by  WMS request manager. We could
either trap any erros at the sld  level and send a wms exception or at least
have the errors logged as debugging info. I have entered a bug on this and will
go through it before next release.

[tomkralidis]

Assefa: I just built svn trunk without OGR and made a WMS GetMap request with an SLD. The response never gets to the SLD check as it returns an exception saying OGR is not available. I verified this by trying a GetMap request without passing an SLD and get an exception. This was on a vector layer (so I'm guessing the "no OGR" error was coming from the data fetching).

Trying this on a raster layer returned no error, even if I put in a 404 SLD document.

I've updated mapwms.c to, if SLD or SLD_BODY is passed, first check if OGR is enabled. If not, return exception, if it is, process as per usual. See r6538 for the changeset.

Let me know if these changes are okay, then we can close this one.

[assefa]

Tom, changes seem to be correct as far as I can tell. If you have tested it, please close the bug. Thanks.