[WMS] Get rid of exception in DTD path for OGC CITE testsuite

[dmorissette]

In bug 1576, an exception was added in mapwms.c just to pass the OGC tests:

    /* this exception was added to accomadote the OGC test suite (Bug 1576)*/
    if (strcasecmp(schemalocation, OWS_DEFAULT_SCHEMAS_LOCATION) == 0)
      dtd_url = strcatalloc(dtd_url, "/wms/1.1.1/WMS_MS_Capabilities.dtd");
    else
      dtd_url = strcatalloc(dtd_url, "/wms/1.1.1/capabilities_1_1_1.dtd");


In bug 1873, Tom K. wrote a comment that suggests that this exception may not be
required any more since digitalearth.gov will be shutdown and then the OGC folks
update the CITE test suite to use the official schemas at shemas.opengis.net:

Tom wrote:
-----------

I know.  I'm not sure what that's doing there (oh, ok, bug 1576).  Probably due
to the fact that OGC schemas name the WMS DTD one thing and that digitalearth
names it another.  The OGC schemas site has the identical file with both
filenames (how did that ever happen in the first place?) for compatibility.

In any case, Jeff DLB put out an announcement that digitalearth.gov won't be
supporting the schemas anymore.  OGC mentioned that they would support the
schema location at (then) schemas.opengeospatial.net (can't find the email right
now).

So does this mean the CITE tests will remove the hook to digitalearth.gov?  If
they do in their testing, we can remove the hack as well.

Can someone check w/ the CITE folks?

[dmorissette]

Action item for this bug: someone needs to bring up this issue with the OGC CITE
folks.

Setting target milestone for resolution to 5.0 release.

Assigned to Norm.

[nsavard@…]

Bug 1576 answers to the question.  To pass the OGC tests suite we have to use
http://schemas.opengeospatial.net/wms/1.1.1/WMS_MS_Capabilities.dtd.

[nsavard@…]

I will send an email to Cite list to make sure.

[dmorissette]

http://schemas.opengis.net/wms/1.1.1/ conttains a copy of both DTDs so there is
no relationship between the CITE tests and digitalearth.gov and we should not
expect the CITE tests to change after it's been shutdown.

Also note that the two DTDs are different:

$ diff capabilities_1_1_1.dtd WMS_MS_Capabilities.dtd
192,194c192
<           nearestValue (0 | 1) "0"
<           multipleValues (0 | 1) "0"
<           current (0 | 1) "0">
---
>           nearestValue (0 | 1) "0">

In conclusion, I think we need to keep this exception in the code for now in
order to satisfy the OGC CITE test suite. i.e. if you have your own custom
schemas repository then the DTD with the bugfix (capabilities_1_1_1.dtd ) will
be used, otherwise if you use the default opengis.net repository then the
WMS_MS_Capabilities.dtd is used and the CITE tests can pass.

That's a mess, but we'll close bug as WONTFIX.