Opened 18 years ago

Closed 16 years ago

#1827 closed defect (fixed)

memory leak in gmlWriteGeometry_GML2

Reported by: ross.elliott@… Owned by: mapserverbugs
Priority: high Milestone:
Component: WFS Server Version: 4.8
Severity: normal Keywords:
Cc: tomkralidis

Description

in gmlWriteGeometry_GML2 (mapgml.c) outerlist is allocated twice (see extract below)

-----------------------------------------------

case(MS_SHAPE_POLYGON): /* this gets nasty, since our shapes are so flexible */
    geometry_simple_index = msGMLGeometryLookup(geometryList, "polygon");
    geometry_aggregate_index = msGMLGeometryLookup(geometryList, "multipolygon");
    if(geometry_simple_index >= 0) geometry_simple_name =
geometryList->geometries[geometry_simple_index].name;
    if(geometry_aggregate_index >= 0) geometry_aggregate_name =
geometryList->geometries[geometry_aggregate_index].name;

    /* get a list of outter rings for this polygon */
    outerlist = msGetOuterList(shape);

    /* get a list of outter rings for this polygon */
    outerlist = msGetOuterList(shape);

Change History (4)

comment:1 by tomkralidis, 16 years ago

I can't find this in latest svn mapgml.c anymore. Can you confirm?

comment:2 by tomkralidis, 16 years ago

Cc: tomkralidis added

comment:3 by relliott, 16 years ago

I've just checked the builds I have, it was there in 4.8.1 but not in 4.8.4 or later, so problem fixed.

comment:4 by tomkralidis, 16 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.