Opened 19 years ago

Closed 17 years ago

#1380 closed defect (wontfix)

MapServer WFS should not output LineString with a single coordinate

Reported by: dmorissette Owned by: sdlime
Priority: high Milestone: FUTURE
Component: WFS Server Version: 4.5
Severity: normal Keywords:
Cc:

Description (last modified by sdlime)

Paul Ramsey wrote:
> 
> So, I downloaded CadCorp MapBrowser, and it worked with mapserver 4.4 
> and 4.6. Only one problem, and that was when it was given a LineString 
> with only one coordinate (not legal GML). Which is a data or a server 
> problem, depending on where one wants to point fingers.
>

Change History (8)

comment:1 by dmorissette, 19 years ago

MapServer should probably produce an error (or exception) in mapgml.c instead of
returning a LineString with a single vertex. 

comment:2 by dmorissette, 19 years ago

Milestone: 4.6 release

comment:3 by sdlime, 19 years ago

Similarly it should not output a polygon with 2 verts. There's not a good way 
to report errors like this midway through outputing a document. Would it be 
enough to output a warning comment and then carry on?

Since I'd point the finger at the data guy do you want to hold up 4.6? I'd say 
no.

comment:4 by refractions, 19 years ago

Don't hold 4.6, this has an obvious workaround (fix your data). Some kind of
warning emitted would be good (this is where mapserver log levels can be great))
but it is a hard balancing act: simply dying is mean, but silently "fixing" or
omitting the feature is also mean.

comment:5 by dmorissette, 19 years ago

Steve, would you want to take this bug since you were the last one to play in
the GML code?

comment:6 by sdlime, 19 years ago

Owner: changed from mapserverbugs to sdlime
Will do... I think a warning (and no feature) is about as good as we can do.
Will add to 4.7 first and then back port.

Steve

comment:7 by dmorissette, 19 years ago

Cc: assefa@… added

comment:8 by sdlime, 17 years ago

Description: modified (diff)
Milestone: 5.0 releaseFUTURE
Resolution: wontfix
Status: newclosed

I checked and there is no check for degenerate features of any type (e.g. 2 point polygons, 1 point lines etc...). It doesn't seem to be a huge problem so I'm marking as wontfix at this point. Can always reopen if necessary.

Steve

Note: See TracTickets for help on using tickets.