Opened 19 years ago

Closed 19 years ago

#1210 closed defect (fixed)

Problem with msOCISetLayerInfo function

Reported by: fsimon@… Owned by: fsimon@…
Priority: high Milestone:
Component: Input - Native Oracle Spatial Support Version: 4.4
Severity: normal Keywords:
Cc:

Description 

In function msOracleSpatialLayerOpen when occour the call for the
msOCISetLayerInfo function and if occour one internal error in this function
layerinfo will receive NULL.
   So, the connection handlers in layerinfo->orahandlers will be drop. This
problem will generate many critical bugs in the next functions. 
   The wrong code is:
      ....
         if ( !success ) {
          layerinfo = NULL;
      ....
   Thanks.

Change History (2)

comment:1 by fsimon@…, 19 years ago

Status: new → assigned 
   The solution is changing the msOCISetLayerInfo function. Now the function
need to return the success value.
   So, in the msOracleSpatialLayerOpen the control will change:
From:
"if (layerinfo == NULL)"
To
"if (!msOCISetLayerInfo)"
   Now the correct functions (msOCIClearLayerInfo, msOCICloseHandlers and
msOCICloseLayerInfo) will clean the oracle handlers when occour errors.
   Thanks.

comment:2 by fsimon@…, 19 years ago

Resolution: → fixed
Status: assigned → closed 
Fixed in CVS version of maporaclespatial.c in Mapserver 4.5.
Thanks.
Note: See TracTickets for help on using tickets.