msSetError doesn't zero terminate routine name

[jerry.pisk@…]

If a routine name is longer then ROUTINELENGTH then msSetError fails to zero 
terminate it in the new errorObj object.

[jerry.pisk@…]

maperror.c patch

[sdlime]

CC'ing Dan et al for review...

Steve

[dmorissette]

I agree with the patch except that setting ms_error->routine[ROUTINELENGTH]='\0'
will write one byte past the end of the buffer. The last byte in the buffer is
at index ROUTINELENGTH-1, so the patch should become:


Index: maperror.c
===================================================================
RCS file: /data2/cvsroot/mapserver/maperror.c,v
retrieving revision 1.61
diff -u -r1.61 maperror.c
--- maperror.c	28 Jan 2005 06:16:53 -0000	1.61
+++ maperror.c	30 Jan 2005 18:38:04 -0000
@@ -295,8 +295,10 @@
 
   if(!routine)
     strcpy(ms_error->routine, "");
-  else
+  else {
     strncpy(ms_error->routine, routine, ROUTINELENGTH);
+    ms_error->routine[ROUTINELENGTH-1] = '\0';
+  }
 
   if(!message_fmt)
     strcpy(ms_error->message, "");

[sdlime]

Applied Dan's modified patch, thanks to both of you guys.

Steve

[sdlime]

Closing, already patched.