Opened 19 years ago

Closed 15 years ago

#1178 closed defect (invalid)

[PATCH] Please add define for flagging unused arguments

Reported by: pere@… Owned by: aboudreault
Priority: high Milestone: 5.6 release
Component: Build Problems Version: 4.4
Severity: normal Keywords:
Cc: dmorissette

Description (last modified by dmorissette)

When instructing GCC to report as many warnings as possible, it detect several unused function arguments in the source. Some of these arguments are supposed to be unused. It would be nice to be able to flag such arguments as unused in a way that keep gcc quiet.

The attached patch will add such UNUSED flag to map.h, as suggested earlier on mapserver-dev@.

Attachments (1)

flag-unused.diff (629 bytes ) - added by pere@… 19 years ago.
Add UNUSED flag to map.h.

Download all attachments as: .zip

Change History (5)

by pere@…, 19 years ago

Attachment: flag-unused.diff added

Add UNUSED flag to map.h.

comment:1 by tomkralidis, 15 years ago

Is this still valid?

comment:2 by dmorissette, 15 years ago

Cc: dmorissette added
Description: modified (diff)
Milestone: 5.6.0 release
Owner: changed from mapserverbugs to aboudreault

Alan, can you please check this?

comment:3 by aboudreault, 15 years ago

Excepted these two warnings: "warning: ‘cvsid_aw’ defined but not used" and "warning: ignoring return value of", there is no ~"unused function arguments warning". Is it about these warnings you were talking ?

comment:4 by aboudreault, 15 years ago

Resolution: invalid
Status: newclosed

Closed as invalid. The recent trunk doesn't have all those warnings.

Note: See TracTickets for help on using tickets.