Ticket #1114 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

shape.text has no effect on labels

Reported by: sgillies@… Owned by: sdlime
Priority: high Milestone: 4.4 release
Component: MapServer C Library Version: 4.4
Severity: normal Keywords:
Cc:

Description 

Although our shapeObjs have a 'text' member and we can set this member through
mapscript, msShapeGetAnnotation() does not check this value for use as a 
feature label.

Change History

Changed 8 years ago by sgillies@…

  • milestone set to 4.4 release 
setting target.  i'll pick this one up if you are busy.

Changed 8 years ago by sdlime 

I didn't add the msShapeGetAnnotation function so I'm not sure what's going on.
This is probably not a result of any updates, just something that was missed. Go
ahead if you like. I'm curious though and would like to see what you have to fix.

Steve

Changed 8 years ago by sdlime 

Hmmm... The text property was always meant to be set and used with the shape
draw method. Only the layer drawing methods call that annotation function. How
is this being used in MapScript?

Steve

Changed 8 years ago by sgillies@…

  • status changed from new to closed
  • resolution set to fixed 
Only change I made to msShapeGetAnnotation is to protect against trying get
a value when shape->values is NULL.  One less possible segfault.

Implemented a setValue() method for mapscript and 4 default values for newly
created shapeObjs through mapscript.  This allows us to pop values into a 
shape that can be used for labeling.
Note: See TracTickets for help on using tickets.