Opened 20 years ago

Closed 20 years ago

Last modified 20 years ago

#1024 closed defect (fixed)

small bugfix for nested layer_groups (WMS)

Reported by: silke@… Owned by: mapserverbugs
Priority: high Milestone: 4.4 release
Component: WMS Server Version: unspecified
Severity: normal Keywords:
Cc: bartvde@…, paul.den.dulk@…

Description

When the wms_layer_group is used for some layers but not for all it can happen
that writing the Capabilities stops because the mapserver tries to read an empty
numNestedGroups. The small patch under URL fixes the problem for me.

Many greetings,

Silke

Change History (7)

comment:1 by dmorissette, 20 years ago

Cc: bartvde@… added
Milestone: 4.4 release
Status: newassigned
Looking into this now

comment:2 by dmorissette, 20 years ago

Resolution: fixed
Status: assignedclosed
Fixed (will be in 4.4.0-beta2). Instead of applying the patch directly, I fixed
the function msIsSubGroup() to return MS_FALSE if numOtherGroups==0. This was a
trivial fix, but unfortuately I don't have a mapfile to test this, so could you
please test it and confirm that it works ok. Thanks.

comment:3 by silke@…, 20 years ago

Yes, it is OK now. Thank you for your fast reply and for fixing the code :-)

Silke

comment:4 by paul.den.dulk@…, 20 years ago

hi, I wrote this code. Could I also test your fix to find out what went wrong?

Paul.

comment:5 by bartvde@…, 20 years ago

Paul, the fix from Silke can be found on the following URL:

http://ftp.intevation.de/users/silke/mapserver/mapserver-4.4.0-layergroup.patch

Daniel changed this fix a bit, and his fix is in the latest CVS I assume.

comment:6 by bartvde@…, 20 years ago

Cc: paul.den.dulk@… added
Added Paul to the cc so he will receive my post .... :)

comment:7 by dmorissette, 20 years ago

Yes, my fix is in CVS and is is different from Silke's patch. Just get the
latest source from CVS and yoou can test it.
Note: See TracTickets for help on using tickets.