Changes between Version 23 and Version 24 of MapGuideCodingStandards

Timestamp:

Jul 24, 2008, 1:34:53 PM (16 years ago)

Author:

tomfukushima

Comment:

--

MapGuideCodingStandards

@@ -67 +67 @@
 ///Description of parameter element
 ///</param>
-///<param name="sFileName">
-///Description of parameter sFileName
+///<param name="fileName">
+///Description of parameter fileName
 ///</param>
 /// <returns></returns> 
-private bool CanIgnoreElement(Element element, string sFileName)
+private bool CanIgnoreElement(Element element, string fileName)
 }}}
 
@@ -219 +219 @@
 == IDE Settings ==
 
-It is recommended that you use Visual Studio .NET for software development on Windwos and it helps if some settings are the same for all users.  Here are the ones you should make sure are set.
+It is recommended that you use Visual Studio .NET for software development on Windows and it helps if some settings are the same for all users.  Here are the ones you should make sure are set.
 
 Under Tools/Options/Text Editor/All Languages/Tabs, make sure the tab size is set to 4 and that the ‘Insert spaces’ option is turned on.  The use of spaces everywhere rather than a mix of tabs and spaces has the following advantages:
@@ -468 +468 @@
 }}}
 
-A try-catch statement may also be followed by `finally` which is always executed.
+A try-catch statement may also be followed by `finally` which is always executed (unless an exception is thrown in the body of an executed catch).
 {{{
 #!cpp
@@ -546 +546 @@
 
 A pointer should always be checked before using. You should never assume that the pointer will be valid.
-This is a good coding style and should be done.
-{{{
-#!cpp
-if (pData != NULL)
-{
-    int nSize = pData->GetSize();
+This is good coding style and should be done.
+{{{
+#!cpp
+if (NULL != data)  // note order of operands in the expression
+{
+    int size = data->GetSize();
     ...
 }
@@ -559 +559 @@
 {{{
 #!cpp
-int nSize = pData->GetSize();
+int size = data->GetSize();
 }}}
 
@@ -580 +580 @@
 MgRepository* MgServerResourceService::CreateRepository(CREFSTRING repositoryType, CREFSTRING repositoryName)
 {
-    Ptr<MgRepository> repository = 0;
+    Ptr<MgRepository> repository;
 
     MG_RESOURCE_SERVICE_TRY()
-
-    MgResourceServiceUtil::CheckArgument(!repositoryName.empty());
 
     if (MgRepositoryType::Library == repositoryType)
@@ -596 +594 @@
     else
     {
-        throw new MgInvalidRepositoryTypeException(__FILE__, __LINE__);
+        throw new MgInvalidRepositoryTypeException(__LINE__, __WFILE__);
     }
 
-    MgResourceServiceUtil::CheckMemory(repository);
-
     MG_RESOURCE_SERVICE_CATCH_AND_THROW()
 
-    assert(0 == mgException);
-
-    (*repository).AddRef();     // Ownership is transferred to the caller
-
-    return repository;
+    return repository.Detach();
 }
 }}}
@@ -654 +646 @@
     MG_CATCH()
 
-    if (0 != mgException)
+    if (NULL != mgException)
     {
         delete[] bar;
-        throw mgException;
+        (*mgException).AddRef();
+        mgException->Raise();
     }
 
@@ -751 +744 @@
 {
     mdXY = 0,   /// XY
-    mdXYM,              /// XY + Measure
-    mdXYZ,              /// XYZ
-    mdXYZM,             /// XYZ + Measure
+    mdXYM,      /// XY + Measure
+    mdXYZ,      /// XYZ
+    mdXYZM,     /// XYZ + Measure
 };
 }}}