Opened 10 years ago

Last modified 10 years ago

#915 new defect

text css as element-var

Reported by: marcm Owned by: dev
Priority: major Milestone: 2.8 release
Component: administration Version: 2.7.3
Keywords: Cc:

Description

Since Mapbender 2.7 the "text/css" statements in element-var doesnt work. (File/css works fine)

The reason is in a comment block (<!-- ) in index.php before the text css is produced.

see: 

<style type="text/css">
	<!--
	<?php
	        $sql = <<<SQL
	       
	SELECT DISTINCT e_id, e_element, var_value, var_name, var_type FROM gui_element, gui_element_vars
	WHERE
	        e_id = fkey_e_id
	        AND e_element <> 'iframe'
	        AND gui_element.fkey_gui_id = $1
	        AND gui_element_vars.fkey_gui_id = $1
	        AND var_type = 'text/css'
	ORDER BY var_name
	
	SQL;
	
	        $v = array($gui_id);
	        $t = array('s');
	        $res = db_prep_query($sql,$v,$t);
	        $cnt = 0;
	        while($row = db_fetch_array($res)){
	                echo $row["var_value"] . "\n";
	        }
	?>
	-->
	</style>

With Mapbender 2.6 everything worked fine. Maybe the different Doctype declaration...?. MB2.6= <!DOCTYPE HTML PUBLIC "-W3CDTD HTML 4.01 TransitionalEN">

MB2.7= <!DOCTYPE HTML PUBLIC "-W3CDTD HTML 4.01 TransitionalEN" ​http://www.w3.org/TR/html4/loose.dtd">

I think deleting the comment statement should solve this. (I hope this causes no other Browser incompatibility... :-) ) What do you think?

Change History (1)

comment:1 by marcm, 10 years ago

Milestone: 2.7.4 release → 2.8 release
Note: See TracTickets for help on using tickets.