Ticket #455 (closed defect: fixed)

Opened 4 years ago

Last modified 15 months ago

Dynamic print frame

Reported by: christoph Owned by: christoph
Priority: major Milestone: 2.7.3 release
Component: print Version: 2.7
Keywords: Cc: mschulz, astrid_emde, armin11, huebi

Description

The printable extent should be displayed in the map as an individual frame (currently, the map size is adjusted to represent the print size).

The print frame shall have the following properties

  • movable via drag and drop
  • rotatable via mouse and form element (angle)
  • resizable via mouse and form element (scale)

A prototype has been created. A demo will follow shortly.

Open issues

  • rotated north arrow
  • rotated map extent has to be highlighted in overview in PDF
  • scale in PDF is not correct (scale of map is used, not of frame)
  • php5-imagick installation on demo server
  • sandclock during PDF generation
  • button for print frame if print dialogue is in iframe (not in popup)
  • transparency display in IE

Attachments

pdf.jpg Download (102.4 KB) - added by marcjansen 4 years ago.
distorted pdf
settings.jpg Download (129.3 KB) - added by marcjansen 4 years ago.
settings for distorted pdf

Change History

  Changed 4 years ago by christoph

Done

  • rotated map extent has to be highlighted in overview in PDF
  • scale in PDF is not correct (scale of map is used, not of frame)
  • php5-imagick installation on demo server

Open issues

  • rotated north arrow (is included, but transparency issue)
  • sandclock during PDF generation
  • button for print frame if print dialogue is in iframe (not in popup)
  • transparency display in IE (could be a wzGraphics thing? I'm using Filter:Alpha(Opacity=50))

  Changed 4 years ago by saith

  • priority changed from major to minor

If possible, annotations should be rotated, too.

  Changed 4 years ago by saith

  • priority changed from minor to major

Changed 4 years ago by marcjansen

distorted pdf

Changed 4 years ago by marcjansen

settings for distorted pdf

  Changed 4 years ago by marcjansen

settings.jpg shows settings that result in an incorrect pdf (pdf.jpg). Am I to early in testing?

  Changed 4 years ago by astrid_emde

saith wrote: If possible, annotations should be rotated, too.

  • This is an issue the WMS has to handle
  • a solution could be - the rotation value is added to the MapRequest? -> the WMS adds the rotation to the angle of the text, so that the text rotates too

follow-up: ↓ 23   Changed 4 years ago by astrid_emde

Open issues

  • i18n: add translation for angle
  • north arrow with transparent background

Bugs

  • afm does not work on windows - we need to choose a different afm

follow-up: ↓ 11   Changed 4 years ago by astrid_emde

Bug

  • rotate by mouse: sometimes the rotation by mouse does produce the following error (at the moment I can't reproduce at what situation it accurs)

Fehlermeldung mod_printPDF.php Zeile 49

48 if (typeof(obj.angle) == "number") {
49 document.form1.angle.value = obj.angle;
50 }

document is null
[Break on this error] document.form1.angle.value = obj.angle;

  • the red cicle sometimes disappears (at the moment I can't reproduce at what situation it accurs)

  Changed 4 years ago by astrid_emde

  • cc astrid_emde added
  • owner changed from user to christoph

  Changed 4 years ago by astrid_emde

  • cc armin11 added

in reply to: ↑ 8   Changed 4 years ago by mschulz

Astrid, I realized the same thing, it seemed to me that the red circle disappears when there is not enough space on the map, i.e. you have to zoom out and then it showed up again in my case.

follow-up: ↓ 22   Changed 4 years ago by astrid_emde

Bug

  • when you open the print and change only the orientation to landscape the mapframe and all the other elements are not positioned in the right way in the pdf

You can see the bug in the demo:

  Changed 4 years ago by astrid_emde

  • add print.css as element_var
INSERT INTO gui_element_vars(fkey_gui_id, fkey_e_id, var_name, var_value, context, var_type) VALUES('gui1', 'printPDF_dynamic', 'cssfileprintDynamic', '../css/print.css', '' ,'file/css');

follow-up: ↓ 21   Changed 4 years ago by astrid_emde

Enhancement:

  • choose change path: mod_printPDP.php (to make it easier to run print in /print_dynamic_mypath

line 35

	include (dirname(__FILE__)."/".$_REQUEST["conf"]);

line 378

 <form name="form1" method="post" action="mod_printPDF_pdf.php?<?php echo SID; ?>" target="_blank">

  Changed 4 years ago by astrid_emde

Bugs Internet Explorer

  • frame is not transparent
  • wrong scale in textfield and rectangle does not show up
    • when you zoom into the map (1:500) and then hit the print button the rectangle does not show up (we have 1:1000 defined as scale)
  • in addition the field scale in the print module is set to 0

follow-up: ↓ 19   Changed 4 years ago by astrid_emde

Enhancements

  • show tooltips or static information textes at the print rectangle and rotation circle

  Changed 4 years ago by astrid_emde

Bug highquality print

follow-up: ↓ 20   Changed 4 years ago by astrid_emde

Bug

  • lot of northarrows come together in the tmp directory. They should be deleted after integration into the pdf (imagedestroy($image); )

in reply to: ↑ 16   Changed 4 years ago by christoph

Replying to astrid_emde:

Enhancements * show tooltips or static information textes at the print rectangle and rotation circle

this is not possible. We use the mouse cursor to indicate the user can interact with these items

in reply to: ↑ 18   Changed 4 years ago by christoph

Replying to astrid_emde:

Bug * lot of northarrows come together in the tmp directory. They should be deleted after integration into the pdf (imagedestroy($image); )

I disagree, that's what the tmp dir is for. You can also cache the north arrow this way and avoid server load

in reply to: ↑ 14   Changed 4 years ago by christoph

Replying to astrid_emde:

Enhancement: * choose change path: mod_printPDP.php (to make it easier to run print in /print_dynamic_mypath line 35 {{{ include (dirname(FILE)."/".$_REQUESTconf?); }}} line 378 {{{ <form name="form1" method="post" action="mod_printPDF_pdf.php?<?php echo SID; ?>" target="_blank"> }}}

done

in reply to: ↑ 12   Changed 4 years ago by christoph

Replying to astrid_emde:

Bug * when you open the print and change only the orientation to landscape the mapframe and all the other elements are not positioned in the right way in the pdf You can see the bug in the demo: *  http://80.246.114.143/mapbender25/frames/login.php?&name=demo&password=demo&mb_user_myGui=print_dynamic

this is what marc already mentioned in his comment. please avoid redundancy.

bug is fixed

in reply to: ↑ 7   Changed 4 years ago by christoph

Replying to astrid_emde:

Open issues * i18n: add translation for angle

already exists in printPDF_b.conf line 85-86

  Changed 4 years ago by astrid_emde

  • priority changed from major to minor

Enhancement

  • at the moment the rectangle is refreshed onchange of the textfields angle and scale
  • the user has to click somewhere else in the printwindow to fire the event. this is not nice. If you don't know this behaviour you wonder why the printframe is not refreshed after change of the text

suggestion for a solution

  • immediate refresh of the printframe after change of the text
  • keep the onchange like it is now but add a button refresh in the printwindow to refresh the printframe

  Changed 4 years ago by astrid_emde

Bug highquality print

  • bug is fixed $mapFactor added

  Changed 4 years ago by astrid_emde

Bug Northarrowsize

  • when you reduce the size of the north arrow this has no result on the northarrow size in the pdf

see printPDF_b.conf

 * $northarrowImage_width = 8;  #15
 * $northarrowImage_height = 17; #35

  Changed 4 years ago by astrid_emde

Performace

  • highquality print is rather slow. we should have a look whether we can enhance the performance somehow

  Changed 4 years ago by astrid_emde

  • cc nimix added

Bug Internet Explorer (noticed with IE 7)

  • I open the print-window, the printframe appears, pdf-print works fine
  • when I close the print-window and open it again, the printframe is not shown and the scale is set to 1:0. When I change the scale to something reasonable the printframe is still not visible

  Changed 4 years ago by nimix

* Opening the print-window a second time in IE should work now (including scale problem) * The Box opacity should apply also in IE

follow-up: ↓ 31   Changed 4 years ago by astrid_emde

  • cc mschulz added
  • Michael Schulz (mschulz) is merging printdynamic and print with pdf template
  • mschulz - I added you to the cc list

Enhancement

  • when the printframe does not appear, because the size is to small or too big, it would be nice to show a message

in reply to: ↑ 30   Changed 4 years ago by mschulz

Replying to astrid_emde: The problem of a not-fitting printframe only arises when starting with a fixed scale. In out last discussion we decided to adjust the size of the printframe relative to the mapframes scale. This assures that the printfraem will always fit into the mapframe (better mapdiv).

  Changed 3 years ago by astrid_emde

Bugs

  • 1. when the printframe is displayed and you use pan to navigate and then you want to move the printframe it sticks to your mouse and you can't position it
  • 2. when you use textfields like angle and scale in the template and you change the value in the field (like angle 90) and then you hit return you would expect that the angle of the printframe would change. Instead the print process is started and you get the pdf. That is not what the user wants

  Changed 3 years ago by astrid_emde

  • 3. is the angle of the frame correct?
  • 4. only one print frame shoul show up
  • 5. does the module work with IE?

  Changed 2 years ago by astrid_emde

  • 2. fixed: in mb_print.php - keyevents are handled for inut fields

  Changed 2 years ago by christoph

Open Issue: wz_jsgraphics is not working in IE8. Maybe a zIndex issue.

  Changed 2 years ago by christoph

  • milestone changed from 2.7 release to 2.8 release

  Changed 2 years ago by astrid_emde

  • cc nimix removed

FIXED

  • js-configurations are displayed in IE

Open Issue

  • the print frame is not displayed on klick on the image -> wz_jsgraphics is not working in IE8. Maybe a zIndex issue. zIndex is set to 1000

  Changed 2 years ago by astrid_emde

Open Issue

  • the print frame is not displayed on klick on the image -> wz_jsgraphics is not working in IE8. Maybe a zIndex issue. zIndex is set to 1000
  • write date / time in pdf output
  • event handling navigation map / move printframe
  • draw print frame with raphaelJS instead of wzgraphics
  • export sketches to output (like in the old print module)

  Changed 2 years ago by astrid_emde

  • milestone changed from 2.7.1 release to future
  • in IE8 the print frame is displayed

Open Issues are postponed to next minor release

  Changed 2 years ago by astrid_emde

  • version set to 2.7
  • milestone changed from future to 2.7.1 release

Done

  • write date / time in pdf output
  • export sketches to output (like in the old print module) - sketches done with the module measure are exported to the prnt output

Open Issue

  • the print frame is not displayed on klick on the image -> wz_jsgraphics is not working in IE8. Maybe a zIndex issue. zIndex is set to 1000
  • event handling navigation map / move printframe
  • draw print frame with raphaelJS instead of wzgraphics

  Changed 2 years ago by astrid_emde

ToDo?

  • koordinates without spaces - change in print/classes/mbMapDecorator.php

  Changed 2 years ago by huebi

  • cc huebi added

Done

  • add template for print in A2-landscape
  • add northarrow_simple.png

  Changed 2 years ago by huebi

Done

  • add template for print in A1-landscape
  • add template for print in A2-landscape

  Changed 2 years ago by huebi

  • priority changed from minor to major
  • type changed from feature request to defect

Open Issue

  • in the high-qualitiy-print-mode the overview map is not displayed in high quality mode in the pdf document

  Changed 2 years ago by astrid_emde

Open Issue

  • draw print frame with raphaelJS instead of wzgraphics
  • export sketches to output (like in the old print module)
  • the print frame is not displayed on klick on the image -> wz_jsgraphics is not working in IE8. Maybe a zIndex issue. zIndex is set to 1000
  • event handling navigation map / move printframe
  • if you change the scale in the textfield 1 is changed to 0 so you can't write maybe 1000 it always ends up to 0000
  • if a print takes too long and the result is not given back, you can't abort the printing
  • big prints can take some minutes, in this time it is difficult to continue the work in mapbender as the printframe is in the way
  • when the printframe is too big it disappears (maybe a big frame can be better displayed with raphaelJS)
  • (draw print frame with raphaelJS instead of wzgraphics )

  Changed 2 years ago by astrid_emde

Open Issue

  • draw print frame with raphaelJS instead of wzgraphics
  • export sketches to output (like in the old print module)
  • the print frame is not displayed on klick on the image -> wz_jsgraphics is not working in IE8. Maybe a zIndex issue. zIndex is set to 1000
  • event handling navigation map / move printframe
  • if you change the scale in the textfield 1 is changed to 0 so you can't write maybe 1000 it always ends up to 0000
  • if a print takes too long and the result is not given back, you can't abort the printing
  • big prints can take some minutes, in this time it is difficult to continue the work in mapbender as the printframe is in the way
  • when the printframe is too big it disappears (maybe a big frame can be better displayed with raphaelJS)
  • (draw print frame with raphaelJS instead of wzgraphics )
  • temporary files have to be deleted after creation (has been unlink true in the old print module)

  Changed 2 years ago by verenadiewald

  • milestone changed from 2.7.1 release to 2.7.2 release

  Changed 2 years ago by astrid_emde

opened single tickets for the bugs/enhancement.

have a look at:

  Changed 22 months ago by astrid_emde

  • milestone changed from 2.7.2 release to 2.7.3 release

  Changed 21 months ago by verenadiewald

wz_jsgraphics now works in IE 8 after updating version to 3.05

  Changed 15 months ago by verenadiewald

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.