r.mfilter.fp segfaults when divisor is 0

[juliocc]

r.mfilter.fp segfaults when the divisor is 0 because of an error in getfilt.c.

I'm attaching a patch that fixes this problem.

[juliocc]

Fix

[glynn]

Replying to juliocc:

r.mfilter.fp segfaults when the divisor is 0 because of an error in getfilt.c.

Fixed in 7.0 with r41431.

[neteler]

Fixed also in 6.4 and 6.5 (r41432 and r41433).

Thanks, juliocc.

Markus

[marisn]

This patch breaks 6.4 compilation. There's no "div" in 6.4 and 6.5. Markus - please revert it.

grass_64/raster/r.mfilter $ make
gcc -I/home/maris/soft/grass_64/dist.x86_64-unknown-linux-gnu/include  -g -O2       -DPACKAGE=\""grassmods"\"  -I/home/maris/soft/grass_64/dist.x86_64-unknown-linux-gnu/include -o OBJ.x86_64-unknown-linux-gnu/getfilt.o -c getfilt.c
getfilt.c: In function ‘get_filter’:
getfilt.c:46: warning: format not a string literal and no format arguments
getfilt.c:49: warning: format not a string literal and no format arguments
getfilt.c:71: warning: format not a string literal and no format arguments
getfilt.c:79: warning: format not a string literal and no format arguments
getfilt.c:82: warning: format not a string literal and no format arguments
getfilt.c:87: error: ‘div’ undeclared (first use in this function)
getfilt.c:87: error: (Each undeclared identifier is reported only once
getfilt.c:87: error: for each function it appears in.)
getfilt.c:99: warning: format not a string literal and no format arguments
getfilt.c:105: warning: format not a string literal and no format arguments
getfilt.c:108: warning: format not a string literal and no format arguments
getfilt.c:115: warning: format not a string literal and no format arguments
getfilt.c:122: warning: format not a string literal and no format arguments
getfilt.c:125: warning: format not a string literal and no format arguments
getfilt.c:155: warning: format not a string literal and no format arguments
make: *** [OBJ.x86_64-unknown-linux-gnu/getfilt.o] Error 1

[juliocc]

The patch is against r.mfilter.fp. Revisions r41432, r41433 applied the patch to r.mfilter

[neteler]

Sorry, done. I was tricked by the different module name.

Reverted previous and really fixed in 6.4 and 6.5 with r41438 and r41440.