Ticket #67 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

r.out.gdal type= and no-data issues

Reported by: sieczka Owned by: martinl
Priority: critical Milestone: 6.3.0
Component: Default Version: unspecified
Keywords: gdal Cc: grass-dev@…, warmerdam
Platform: CPU:

Description

If data 'type' is not specified and the input raster has nulls, r.out.gdal picks a correct datatype automatically, but sets a bogus no-data value. Example, in spearfish60:

r.out.gdal in=geology out=gelogy.tif
Exporting to GDAL data type: Byte
 100%
WARNING: Input raster map constains cells with NULL-value (no-data). For
         no-data values was used value -2147483648. You can specify nodata
         value by nodata parameter.
r.out.gdal complete.

Note the bogus -2147483648 no-data value, not in Byte datatype range.

If the user specifies 'type=Byte' explicitely, r.out.gdal sets nodata to 255 by default (OK):

GRASS 6.3.svn (spearfish60):~ > r.out.gdal in=geology out=gelogy2.tif type=Byte
Exporting to GDAL data type: Byte
 100%
WARNING: Input raster map constains cells with NULL-value (no-data). For
         no-data values was used value 255. You can specify nodata value by
         nodata parameter.
r.out.gdal complete.

Attachments

r-out-gdal-no-data.diff Download (0.8 KB) - added by martinl 4 years ago.
The attached patch should fix this issue.

Change History

Changed 4 years ago by martinl

The attached patch should fix this issue.

follow-up: ↓ 4   Changed 4 years ago by martinl

  • cc grass-dev@… added
  • keywords gdal added
  • status changed from new to assigned
  • owner changed from grass-dev@… to martinl

Please test the attached patch. Martin

follow-up: ↓ 3   Changed 4 years ago by neteler

  • cc warmerdam added

I darkly remember that GDAL uses out-of-range values for no data. Possible?

See also

 http://lists.osgeo.org/pipermail/grass-dev/2007-May/031316.html

 http://lists.osgeo.org/pipermail/grass-dev/2007-May/031715.html

Markus

in reply to: ↑ 2   Changed 4 years ago by martinl

Replying to neteler:

I darkly remember that GDAL uses out-of-range values for no data. Possible? See also  http://lists.osgeo.org/pipermail/grass-dev/2007-May/031316.html  http://lists.osgeo.org/pipermail/grass-dev/2007-May/031715.html

this should be already fixed, see r29555.

Martin

in reply to: ↑ 1   Changed 4 years ago by martinl

Replying to martinl:

Please test the attached patch. Martin

Patch applied in trunk, r30433. Martin

  Changed 4 years ago by martinl

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.