NVIZ fly mode broken on 64bit systems

[marisn]

Fly mode in NVIZ is broken - when flying around, camera moves for some sec and then resets back to it's initial position.

Buggy on 64bit Ubuntu 7.10 and 64bit OpenSuSE 10.3 (both use Nvidia drivers) with GRASS 6.2.2, 6.2.3, current trunk. 32bit Gentoo (intel driver) with current trunk is not affected - it must be a 64bit problem.

[neteler]

Confirmed on Mandriva 2007.1/64bit with NVIDIA.

[neteler]

Confirmed on Mandriva 2008.0/64bit with NVIDIA.

[marisn]

Doesn't seem to make to 6.4.0.

[kwasnicki]

looks like the problem is a float overflow in togl_flythrough.c:this_time() function. changing the (float) casts to (double) has fixed this on my 64bit slackware install.

diff attached... although not 100% sure if i created the diff patch properly, but this is just a one line change so i'm sure the code maintainer can replicate the necessary change if the diff doesn't work. ;-)

[hamish]

Replying to kwasnicki:

diff attached... although not 100% sure if i created the diff patch properly, but this is just a one line change so i'm sure the code maintainer can replicate the necessary change if the diff doesn't work. ;-)

it ended up backwards, but it's just a 1 liner so no worries.

preferred method for creating patches is svn diff:

http://grass.osgeo.org/wiki/Bugs#Patches

Hamish

[marisn]

Fixed and backported to 6.4. r42592, r42593, r42594

Thanks to Ken Kwasnicki.