Opened 6 years ago
Closed 6 years ago
#3511 closed enhancement (fixed)
[patch] v.buffer: allow squared buffers around points
| Reported by: | mlennert | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.4.1 |
| Component: | Vector | Version: | svn-trunk |
| Keywords: | v.buffer squared buffer | Cc: | |
| CPU: | Unspecified | Platform: | Unspecified |
Description
The attached patch implements squared buffers around points.
Attachments (2)
Change History (8)
by , 6 years ago
| Attachment: | squared_buffer_around_points.diff added |
|---|
follow-up: 2 comment:1 by , 6 years ago
follow-up: 3 comment:2 by , 6 years ago
Replying to mlennert:
Replying to mlennert:
The attached patch implements squared buffers around points.
Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.
Currently v.buffer always uses Vect_point_buffer2() for points, but the Vect_*_buffer*() functions might disappear at some stage because they are not working properly (apart from point buffering). Therefore it might be safer to add this functionality to v.buffer directly.
by , 6 years ago
| Attachment: | squared_buffer_around_points_directly_in_vbuffer.diff added |
|---|
second version of a patch, this time directly in main.c of v.buffer
follow-up: 4 comment:3 by , 6 years ago
Replying to mmetz:
Replying to mlennert:
Replying to mlennert:
The attached patch implements squared buffers around points.
Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.
Currently v.buffer always uses Vect_point_buffer2() for points, but the Vect_*_buffer*() functions might disappear at some stage because they are not working properly (apart from point buffering). Therefore it might be safer to add this functionality to v.buffer directly.
Please check the attached new patch.
follow-up: 5 comment:4 by , 6 years ago
Replying to mlennert:
Replying to mmetz:
Replying to mlennert:
Replying to mlennert:
The attached patch implements squared buffers around points.
Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.
Currently v.buffer always uses Vect_point_buffer2() for points, but the Vect_*_buffer*() functions might disappear at some stage because they are not working properly (apart from point buffering). Therefore it might be safer to add this functionality to v.buffer directly.
Please check the attached new patch.
The patch looks and works fine, please commit.
comment:5 by , 6 years ago
Replying to mmetz:
Replying to mlennert:
Replying to mmetz:
Replying to mlennert:
Replying to mlennert:
The attached patch implements squared buffers around points.
Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.
Currently v.buffer always uses Vect_point_buffer2() for points, but the Vect_*_buffer*() functions might disappear at some stage because they are not working properly (apart from point buffering). Therefore it might be safer to add this functionality to v.buffer directly.
Please check the attached new patch.
The patch looks and works fine, please commit.
Done in r72353.
Replying to mlennert:
Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.