#3511 closed enhancement (fixed)

[patch] v.buffer: allow squared buffers around points

Reported by: mlennert Owned by: grass-dev@…
Priority: normal Milestone: 7.4.1
Component: Vector Version: svn-trunk
Keywords: v.buffer squared buffer Cc:
CPU: Unspecified Platform: Unspecified

Description

The attached patch implements squared buffers around points.

Attachments (2)

squared_buffer_around_points.diff (754 bytes) - added by mlennert 14 months ago.
squared_buffer_around_points_directly_in_vbuffer.diff (1.3 KB) - added by mlennert 14 months ago.
second version of a patch, this time directly in main.c of v.buffer

Download all attachments as: .zip

Change History (8)

Changed 14 months ago by mlennert

comment:1 in reply to:  description ; Changed 14 months ago by mlennert

Replying to mlennert:

The attached patch implements squared buffers around points.

Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.

comment:2 in reply to:  1 ; Changed 14 months ago by mmetz

Replying to mlennert:

Replying to mlennert:

The attached patch implements squared buffers around points.

Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.

Currently v.buffer always uses Vect_point_buffer2() for points, but the Vect_*_buffer*() functions might disappear at some stage because they are not working properly (apart from point buffering). Therefore it might be safer to add this functionality to v.buffer directly.

Changed 14 months ago by mlennert

second version of a patch, this time directly in main.c of v.buffer

comment:3 in reply to:  2 ; Changed 14 months ago by mlennert

Replying to mmetz:

Replying to mlennert:

Replying to mlennert:

The attached patch implements squared buffers around points.

Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.

Currently v.buffer always uses Vect_point_buffer2() for points, but the Vect_*_buffer*() functions might disappear at some stage because they are not working properly (apart from point buffering). Therefore it might be safer to add this functionality to v.buffer directly.

Please check the attached new patch.

comment:4 in reply to:  3 ; Changed 14 months ago by mmetz

Replying to mlennert:

Replying to mmetz:

Replying to mlennert:

Replying to mlennert:

The attached patch implements squared buffers around points.

Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.

Currently v.buffer always uses Vect_point_buffer2() for points, but the Vect_*_buffer*() functions might disappear at some stage because they are not working properly (apart from point buffering). Therefore it might be safer to add this functionality to v.buffer directly.

Please check the attached new patch.

The patch looks and works fine, please commit.

comment:5 in reply to:  4 Changed 13 months ago by mlennert

Replying to mmetz:

Replying to mlennert:

Replying to mmetz:

Replying to mlennert:

Replying to mlennert:

The attached patch implements squared buffers around points.

Forgot to explain: with the patch, v.buffer should create square buffers around points if the -s flag is set.

Currently v.buffer always uses Vect_point_buffer2() for points, but the Vect_*_buffer*() functions might disappear at some stage because they are not working properly (apart from point buffering). Therefore it might be safer to add this functionality to v.buffer directly.

Please check the attached new patch.

The patch looks and works fine, please commit.

Done in r72353.

comment:6 Changed 13 months ago by mlennert

Resolution: fixed
Status: newclosed

Closing this ticket as fixed.

Note: See TracTickets for help on using tickets.