Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3031 closed enhancement (fixed)

Rotate symbol for north arrow in d.northarrow

Reported by: wenzeslaus Owned by: grass-dev@…
Priority: normal Milestone: 7.2.0
Component: Display Version: unspecified
Keywords: d.northarrow, cartography, gsoc2016, grid north, true north Cc:
CPU: Unspecified Platform: Unspecified

Description

Add to rotation for north arrow which now always points to grid north instead of the true north.

Automatic computation of this based on projection and position would be nice but a constant to rotate by given angle would be more than sufficient.

Attachments (3)

d.northarrow.patch.tar.gz (3.8 KB) - added by lazaa 3 years ago.
Updated patch. User can rotate northarrow with option rotation in degrees or in radians with -r flag. With flag -w the label will rotate with northarrow.
d.northarrow.diff (15.6 KB) - added by lazaa 3 years ago.
diff file
d.northarrow_docs.diff (1.6 KB) - added by lazaa 3 years ago.
updated documentation

Download all attachments as: .zip

Change History (12)

comment:1 Changed 3 years ago by wenzeslaus

Summary: Rotate symbol for nroth arrow in d.northarrowRotate symbol for north arrow in d.northarrow

The label (usually letter N) should be also rotated together with the whole symbol, i.e. considered as a part of the symbol when rotating. Alternatively, "the N" position would rotated but the letter itself would be still vertical. Which option is correct depends on cartography customs for the given field.

Changed 3 years ago by lazaa

Attachment: d.northarrow.patch.tar.gz added

Updated patch. User can rotate northarrow with option rotation in degrees or in radians with -r flag. With flag -w the label will rotate with northarrow.

comment:2 Changed 3 years ago by neteler

Please upload patches as diff files from the source root directory without compression (then it can be read directly in the source code context)

Changed 3 years ago by lazaa

Attachment: d.northarrow.diff added

diff file

comment:3 in reply to:  2 Changed 3 years ago by lazaa

Replying to neteler:

Please upload patches as diff files from the source root directory without compression (then it can be read directly in the source code context)

Sorry for that, my first experience with uploading patches. So I uploaded one .diff file from grass7_trunk root directory which contains differences of all files I had changed during bug fixing. Is it correct now?

comment:4 Changed 3 years ago by annakrat

In 68502:

d.northarrow: improvements - rotate by angle, change label, rotate label, add other existing symbols - see #3019, #3018, #3031, author Adam Laza

comment:5 Changed 3 years ago by annakrat

Thank you, I only changed the default behavior to rotate the label by default.

Please also provide a patch for the updated documentation for the new d.northarrow features.

Changed 3 years ago by lazaa

Attachment: d.northarrow_docs.diff added

updated documentation

comment:6 in reply to:  5 ; Changed 3 years ago by annakrat

I improved the patch and submitted. I suppose all these improvements should be backported to the new 7.2 release branch?

comment:7 in reply to:  6 Changed 3 years ago by neteler

Replying to annakrat:

I improved the patch and submitted. I suppose all these improvements should be backported to the new 7.2 release branch?

IMHO yes.

comment:8 Changed 3 years ago by annakrat

Resolution: fixed
Status: newclosed

Backported in r69051.

comment:9 Changed 3 years ago by annakrat

Milestone: 7.3.07.2.0
Note: See TracTickets for help on using tickets.