Opened 10 years ago
Closed 6 years ago
#2348 closed defect (fixed)
r.stream.order Error finding nodes.
| Reported by: | hcho | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.6.2 |
| Component: | Raster | Version: | svn-trunk |
| Keywords: | r.stream.order | Cc: | |
| CPU: | All | Platform: | All |
Description
When a cell has five tributaries, ram_number_of_tribs (or seg_number_of_tribs) doesn't complain (trib > 5 in line 17), but ram_stream_topology raises a fatal error with the same counting logic (trib > 4 in line 89). I think 5 incoming tributaries, 1 outgoing and 2 non-stream cells should be fine here too.
IMHO, lines 89 and 308 should also be trib > 5 for consistency.
Change History (10)
comment:1 by , 9 years ago
| Milestone: | 7.1.0 → 7.2.0 |
|---|
comment:2 by , 8 years ago
Can you please try again? A series of fixes have been implemented in the past months.
comment:4 by , 8 years ago
| Milestone: | 7.2.1 → 7.2.2 |
|---|
comment:6 by , 7 years ago
Replying to hcho:
When a cell has five tributaries, ram_number_of_tribs (or seg_number_of_tribs) doesn't complain (trib > 5 in line 17), but ram_stream_topology raises a fatal error with the same counting logic (trib > 4 in line 89). I think 5 incoming tributaries, 1 outgoing and 2 non-stream cells should be fine here too.
IMHO, lines 89 and 308 should also be trib > 5 for consistency.
The max number of tributaries has been synced to be 5 in r71703.
comment:8 by , 7 years ago
| Milestone: | → 7.2.4 |
|---|
comment:9 by , 6 years ago
| Milestone: | 7.2.4 → 7.6.2 |
|---|
comment:10 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Milestone renamed