Opened 10 years ago

Closed 10 years ago

#2340 closed defect (fixed)

Rename i.landsat.rgb

Reported by: neteler Owned by: grass-dev@…
Priority: critical Milestone: 7.0.0
Component: Imagery Version: svn-trunk
Keywords: i.landsat.rgb Cc:
CPU: Unspecified Platform: All

Description

Since i.landsat.rgb is not limited at all to be used with LANDSAT, the module should be renamed to a more generic name.

Eg. i.rgb.balance?

This should happen before the 7.0.0 release.

Change History (5)

comment:1 by neteler, 10 years ago

Priority: critical → blocker

more suggestions:

  • i.enhance?
  • i.colors.enhance? # may be confused with r.colors
  • ...?

in reply to:  1 comment:2 by mlennert, 10 years ago

Replying to neteler:

more suggestions:

  • i.enhance?
  • i.colors.enhance? # may be confused with r.colors
  • ...?

I like i.colors.enhance: it's clear about what it does. I don't really see the danger of confusing with r.colors. And it leaves the door open for adding other color enhancement methods into the script (like i.pansharpen for fusion).

BTW: the man page says "It will work with any 8-bit RGB imagery set and the script is easily modified to work with other datasets of greater band-depth." Is the 8-bit limit still the case ? And if yes, if it is easy to do, why not modify it to accept greater depths ?

Moritz

comment:3 by neteler, 10 years ago

i.landsat.rgb renamed to i.colors.enhance in trunk in r61481

in reply to:  3 comment:4 by neteler, 10 years ago

Priority: blocker → critical

Replying to neteler:

i.landsat.rgb renamed to i.colors.enhance in trunk in r61481

Backported to relbr7 in r61483.

If all ok, the ticket may be closed (no idea about the 8 bit question above).

comment:5 by neteler, 10 years ago

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.