Opened 4 years ago

Closed 4 years ago

#2238 closed enhancement (fixed)

minor change in r.stream.segment syntax

Reported by: madi Owned by: grass-dev@…
Priority: minor Milestone: 7.0.0
Component: Raster Version: svn-trunk
Keywords: r.stream.segment Cc: alectoria@…
CPU: Unspecified Platform: Unspecified

Description

Following the unification of syntax used within r.stream.* modules, in r.stream.segment we overlooked to change the input option stream_raster into stream_rast. Since it is now in core and i don't have writing access, could someone kindly do that.

Thanks

Change History (4)

comment:1 Changed 4 years ago by neteler

Component: DefaultRaster

Done in r59509 (trunk) and r59510 (releasebranch_7_0).

BTW: the param description wording is a bit odd.

    in_stm_opt = G_define_standard_option(G_OPT_R_INPUT);
    in_stm_opt->key = "stream_rast";
    in_stm_opt->description = _("Name of input streams mask raster map");

    in_dir_opt = G_define_standard_option(G_OPT_R_INPUT);
    in_dir_opt->key = "direction";
    in_dir_opt->description = _("Name for input raster map with flow direction");

and should perhaps be sync'ed to that of "direction" (in all modules).

comment:2 in reply to:  1 Changed 4 years ago by hellik

Replying to neteler:

Done in r59509 (trunk) and r59510 (releasebranch_7_0).

thanks

BTW: the param description wording is a bit odd.

    in_stm_opt = G_define_standard_option(G_OPT_R_INPUT);
    in_stm_opt->key = "stream_rast";
    in_stm_opt->description = _("Name of input streams mask raster map");

    in_dir_opt = G_define_standard_option(G_OPT_R_INPUT);
    in_dir_opt->key = "direction";
    in_dir_opt->description = _("Name for input raster map with flow direction");

and should perhaps be sync'ed to that of "direction" (in all modules).

yes; any template/example around there to facilitate unification/harmonizing not only for r.stream.* but also for other hydrologically oriented modules?

comment:3 in reply to:  1 ; Changed 4 years ago by madi

Replying to neteler:

Done in r59509 (trunk) and r59510 (releasebranch_7_0).

Thanks

BTW: the param description wording is a bit odd.

    in_stm_opt = G_define_standard_option(G_OPT_R_INPUT);
    in_stm_opt->key = "stream_rast";
    in_stm_opt->description = _("Name of input streams mask raster map");

    in_dir_opt = G_define_standard_option(G_OPT_R_INPUT);
    in_dir_opt->key = "direction";
    in_dir_opt->description = _("Name for input raster map with flow direction");

and should perhaps be sync'ed to that of "direction" (in all modules).

Agreed. Something like: "Name for input raster map with stream network" should do.

comment:4 in reply to:  3 Changed 4 years ago by neteler

Resolution: fixed
Status: newclosed

Replying to madi:

Agreed. Something like: "Name for input raster map with stream network" should do.

Done in r59519 and r59520. Closing.

Note: See TracTickets for help on using tickets.