Opened 11 years ago

Last modified 8 years ago

#2006 new defect

install: extra $GISBASE/etc/wxpython/scripts/Makefile?

Reported by: hamish Owned by: grass-dev@…
Priority: trivial Milestone: 6.4.6
Component: Installation Version: svn-trunk
Keywords: wxpython, compilation, Makefile Cc:
CPU: x86-64 Platform: Linux

Description

Hi,

I notice that $GISBASE/etc/wxpython/scripts/Makefile gets installed.

any reason to keep that?

Change History (4)

in reply to:  description comment:1 by glynn, 11 years ago

Replying to hamish:

I notice that $GISBASE/etc/wxpython/scripts/Makefile gets installed.

gui/wxpython/Makefile does:

SRCFILES := $(wildcard compat/* icons/*.* scripts/* xml/*) \

Note that gui/wxpython/scripts/Makefile is redundant as gui/wxpython/Makefile never recurses into the scripts directory, so scripts/Makefile won't be used unless the user "make"s that directory manually.

Also, many of those "*" wildcards could (and should) be changed to "*.py" to avoid installing cruft such as editor backup files.

comment:2 by hamish, 11 years ago

'*' changed to '*.py' for dirs which only have *.py in them done in trunk and relbr6 with r56744,5, maybe expand to *.py *.html later.

minimal patch to take care of scripts/*.py done in relbr64 with r56757. will backport the rest after the freeze.

Hamish

comment:3 by wenzeslaus, 9 years ago

Keywords: compilation Makefile added
Version: svn-develbranch6svn-trunk

I'm just looking to dist... after compilation not the result of make install but the file (etc/wxpython/scripts/Makefile or now /gui/wxpython/scripts/Makefile) is no longer there.

However there are Makefiles in directories of g.gui.* modules:

$ cd dist...
$ find . -name "*Makefile*"
./gui/wxpython/psmap/Makefile
./gui/wxpython/animation/Makefile
./gui/wxpython/dbmgr/Makefile
./gui/wxpython/tplot/Makefile
./gui/wxpython/rlisetup/Makefile
./gui/wxpython/gmodeler/Makefile
./gui/wxpython/mapswipe/Makefile
./gui/wxpython/timeline/Makefile
./gui/wxpython/iclass/Makefile
./gui/wxpython/vdigit/Makefile

Do we have some bad Makefile template somewhere?

comment:4 by neteler, 8 years ago

Milestone: 6.4.46.4.6
Note: See TracTickets for help on using tickets.