grass-6.4.2 doesn't compile with tk-8.6.0

[syntaxerrormmm]

OS: ArchLinux (rolling release) Behaviour: compiling GRASS from source (6.4.2) fails when building NVIZ with the attached error.

It seems that the required function (TkCopyAndGlobalEval) has been removed from the TK toolkit (8.6.0).

[syntaxerrormmm]

Log file for 'make' launched inside visualization/nviz/src

[syntaxerrormmm]

Verified also on i686. Cannot confirm for other platforms, sorry.

[martinl]

Replying to syntaxerrormmm:

Verified also on i686. Cannot confirm for other platforms, sorry.

related to source:grass/branches/releasebranch_6_4/visualization/nviz/src/draw.c#L35​

any tcl/tk guru here?

[syntaxerrormmm]

I can confirm grass_7 from SVN does compile fine on tk-8.6.0 (x86_64). Is there any ways to backport changes made to NVIZ to 6.4 branch?

[martinl]

Replying to syntaxerrormmm:

I can confirm grass_7 from SVN does compile fine on tk-8.6.0 (x86_64). Is there any ways to backport changes made to NVIZ to 6.4 branch?

there is *no* TCL/TK code in GRASS 7, it's reason why compiles fine against TCL/TK 8.6.

[syntaxerrormmm]

Replying to martinl:

there is *no* TCL/TK code in GRASS 7, it's reason why compiles fine against TCL/TK 8.6.

Ok, sorry, I didn't follow GRASS 7 development.

I'm trying to make a package of GRASS for ArchLinux, so probably the best way (by my side) is to require a version of TK < 8.6.0, hoping that you can fix it in the meantime. I should also notice the maintainer of the 7-svn package, since TCL/TK shouldn't be a requirement anymore.

[mmetz]

Replying to syntaxerrormmm:

OS: ArchLinux (rolling release) Behaviour: compiling GRASS from source (6.4.2) fails when building NVIZ with the attached error.

It seems that the required function (TkCopyAndGlobalEval) has been removed from the TK toolkit (8.6.0).

Within Tcl/Tk,

TkCopyAndGlobalEval(interp, command);

has been replaced with

Tcl_EvalEx(interp, command, -1, TCL_EVAL_GLOBAL);

see

​http://rkeene.org/projects/tcl/tk.fossil/ci/bd1165a06d?sbs=0

Maybe the equivalent

Tcl_EvalEx(cancel_interp, cancel_script, -1, TCL_EVAL_GLOBAL);

works for GRASS 6? Tcl_EvalEx exists in previous versions of Tcl/Tk (8.5 + 8.4).

Markus M

[marisn]

I tested Markus M proposed Tcl_EvalEx change and didn't observe any side effects with tcl 8.6 I would say +1 for commiting.

[syntaxerrormmm]

Patch for fixing the tcl/tk 8.6 issue

[syntaxerrormmm]

Hi all,

I apologize for the long delay. I just tested compiling GRASS 6.4.2 on Archlinux with Tcl/Tk 8.6 and it is compiling fine, on both architectures x86_64 and i686, using the attached patch (as proposed by Markus M). I cannot check the real functionality of the fix since I don't have any idea on how the change would impact on GRASS functionalities.

But +1 for committing.

[yarma]

hi,

applied the fix on draw.c and it's compiling again without error ... didn't test if there is side effect, but it seems to be working !

Sylvain

[mmetz]

Replying to yarma:

hi,

applied the fix on draw.c and it's compiling again without error ... didn't test if there is side effect, but it seems to be working !

I have applied the fix for GRASS 6 in r54796-7. Please test!

Markus M

[msieczka]

Replying to mmetz:

I have applied the fix for GRASS 6 in r54796-7. Please test!

I have just built releasebranch_6_4 and develbranch_6 on Arch against tcl/tk 8.6.0, and given tcl/tk startup, gis.m and NVIZ a quick spearfish60 tour in both builds. No problems noticed.

[martinl]

Seems to be solved, so closing this ticket. Feel free to re-open if needed.