Ticket #1728 (new defect)
Opened 8 months ago
r.slope.aspect: possible data type bug?
|Reported by:||hamish||Owned by:||grass-dev@…|
I noticed what might be a bug in the r.slope.aspect code.
If output map type precision (CELL,FCELL,DCELL) is not given, the data_type variable defaults to DCELL*. According to the code comments, data_type should be wrt the input map, not the output map. (* while the output map type defaults to FCELL)
If output map type is given, the data_type is set to the same. The intention is a bit clearer in the legacy code, a just-now change to today's trunk removed some old code around that.
should it be using Rast_map_type() instead? Which type should the allocs called later with data_type be using?
applies to all branches.
a DCELL input map with prec=int specified on the command line does not cause a segfault in my tests, but none the less the code seems a bit muddled...